Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1666763002: Ensure configure comes from autogen.sh (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
bradn, Sam Clegg
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Ensure configure comes from autogen.sh This is a wild stab at fixing the flake in the gforth build. BUG= https://bugs.chromium.org/p/naclports/issues/detail?id=240 R=sbc@chromium.org Committed: https://chromium.googlesource.com/webports/+/570964f2ea67d1fbab419301f8873628f78e9c33

Patch Set 1 #

Patch Set 2 : revise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ports/gforth/build.sh View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
bradn
4 years, 10 months ago (2016-02-03 18:57:47 UTC) #2
bradn
Dozens of try jobs don't seem to repro this. Shall we land the check?
4 years, 10 months ago (2016-02-03 20:05:19 UTC) #3
Sam Clegg
lgtm
4 years, 10 months ago (2016-02-03 21:12:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666763002/20001
4 years, 10 months ago (2016-02-03 21:16:11 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 21:22:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/webports/+/570964f2ea67d1fbab419301f8873628...

Powered by Google App Engine
This is Rietveld 408576698