Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1666743002: Add --benchType and --sourceType to nanobench. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add --benchType and --sourceType to nanobench. To run only codec benches: $ out/Release/nanobench --images <> --benchType skcodec BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1666743002 Committed: https://skia.googlesource.com/skia/+/65dfd2fe5d93d63b655663707c7233917e293acc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M bench/nanobench.cpp View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mtklein_C
4 years, 10 months ago (2016-02-03 17:56:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666743002/1
4 years, 10 months ago (2016-02-03 17:56:49 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-03 18:22:33 UTC) #8
msarett
lgtm
4 years, 10 months ago (2016-02-03 18:23:05 UTC) #9
scroggo
lgtm
4 years, 10 months ago (2016-02-03 18:23:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666743002/1
4 years, 10 months ago (2016-02-03 18:40:18 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 18:40:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/65dfd2fe5d93d63b655663707c7233917e293acc

Powered by Google App Engine
This is Rietveld 408576698