Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 166673006: SVG rendering ignores xml:space="preserve" attribute for text (Closed)

Created:
6 years, 10 months ago by rwlbuis
Modified:
6 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, rune+blink, apavlov+blink_chromium.org, ed+blinkwatch_opera.com, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

SVG rendering ignores xml:space="preserve" attribute for text Make tspan and textPath inherit the css-whitespace property by default. This means it will either use the same xml:space setting as its parent text container, or use its own xml:space value if provided. This actually fixes text-tspan-02-b.svg. BUG=231508 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167393

Patch Set 1 #

Patch Set 2 : Update max test result #

Patch Set 3 : Update mac test results #

Patch Set 4 : Update mac and linux results #

Patch Set 5 : Add NeedsRebaseline for Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -89 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png View 2 3 Binary file 0 comments Download
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png View 1 Binary file 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt View 1 2 2 chunks +57 lines, -88 lines 0 comments Download
M Source/core/css/svg.css View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
PTAL :)
6 years, 10 months ago (2014-02-18 20:52:12 UTC) #1
pdr.
On 2014/02/18 20:52:12, rwlbuis wrote: > PTAL :) LGTM
6 years, 10 months ago (2014-02-19 00:36:48 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 10 months ago (2014-02-19 00:59:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/166673006/290001
6 years, 10 months ago (2014-02-19 00:59:44 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 03:20:09 UTC) #5
Message was sent while issue was closed.
Change committed as 167393

Powered by Google App Engine
This is Rietveld 408576698