Issue 166673004: Copy folder icon to new location (use and old location removal to follow).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 166673004: Copy folder icon to new location (use and old location removal to follow). (Closed)

Created:
6 years, 10 months ago by vandebo (ex-Chrome)

Modified:
6 years, 10 months ago

Reviewers:
oshima

CC:
chromium-reviews, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Copy folder icon to new location (use and old location removal to follow). BUG=334309, 161119 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251788

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	A +	chrome/app/theme/default_100_percent/common/folder.png	View		Binary file		0 comments	Download
	A +	chrome/app/theme/default_200_percent/common/folder.png	View		Binary file		0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

relanding https://codereview.chromium.org/130263007/

6 years, 10 months ago (2014-02-14 21:58:44 UTC) #1

vandebo (ex-Chrome)

The CQ bit was checked by vandebo@chromium.org

6 years, 10 months ago (2014-02-14 21:58:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/166673004/1

6 years, 10 months ago (2014-02-14 22:04:26 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-14 22:25:52 UTC) #4

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50446

6 years, 10 months ago (2014-02-14 22:25:52 UTC) #5

vandebo (ex-Chrome)

6 years, 10 months ago (2014-02-18 17:27:29 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r251788 (presubmit successful).

Expand Messages | Collapse Messages