Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 16667017: Revert 198272 "cc: Move canvas clear from picture to picture_pil..." (Closed)

Created:
7 years, 6 months ago by trchen
Modified:
7 years, 6 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Revert 198272 "cc: Move canvas clear from picture to picture_pil..." > cc: Move canvas clear from picture to picture_pile_impl > > This moves a clear per picture into a clear-to-background color > per picture pile. We need this to ensure that a solid color > page in low res is considered solid, since all the draws are > of the same color. > > BUG=233622 > > Review URL: https://chromiumcodereview.appspot.com/14322017 TBR=vmpstr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -22 lines) Patch
M cc/resources/picture.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M cc/resources/picture_pile_impl.cc View 1 chunk +18 lines, -8 lines 0 comments Download
M skia/ext/analysis_canvas.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
trchen
7 years, 6 months ago (2013-06-10 20:45:48 UTC) #1
trchen
Committed patchset #1 manually as r205298.
7 years, 6 months ago (2013-06-10 20:46:09 UTC) #2
tomhudson
Why the revert?
7 years, 6 months ago (2013-06-10 20:47:36 UTC) #3
trchen
On 2013/06/10 20:47:36, tomhudson wrote: > Why the revert? https://code.google.com/p/chromium/issues/detail?id=245349 Note: The patch was already ...
7 years, 6 months ago (2013-06-10 20:50:18 UTC) #4
trchen
On 2013/06/10 20:50:18, trchen wrote: > On 2013/06/10 20:47:36, tomhudson wrote: > > Why the ...
7 years, 6 months ago (2013-06-10 20:59:26 UTC) #5
trchen
On 2013/06/10 20:59:26, trchen wrote: > On 2013/06/10 20:50:18, trchen wrote: > > On 2013/06/10 ...
7 years, 6 months ago (2013-06-10 21:05:20 UTC) #6
vmpstr
7 years, 6 months ago (2013-06-10 21:06:39 UTC) #7
Message was sent while issue was closed.
On 2013/06/10 21:05:20, trchen wrote:
> On 2013/06/10 20:59:26, trchen wrote:
> > On 2013/06/10 20:50:18, trchen wrote:
> > > On 2013/06/10 20:47:36, tomhudson wrote:
> > > > Why the revert?
> > > 
> > > https://code.google.com/p/chromium/issues/detail?id=245349
> > > Note: The patch was already reverted on trunk. This is for M28.
> > 
> > Wait, I just realized the "revert" patch on trunk is not a trivial revert.
> > Should I re-apply r198272 then cherry-pick r198826 instead?
> 
> Oh please ignore my previous comment. It is a trivial revert reusing the same
> code review issue#.

Oops. I'll know better in the future.

Powered by Google App Engine
This is Rietveld 408576698