Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1666673002: Version 4.10.145.1 (cherry-pick) (Closed)

Created:
4 years, 10 months ago by Michael Hablich
Modified:
4 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.10.145
Target Ref:
refs/pending/heads/4.10.145
Project:
v8
Visibility:
Public.

Description

Version 4.10.145.1 (cherry-pick) Merged db47a31fb9ce Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a … (patchset #3 id:80001 of https://codereview.chromium.org/1642223003/ ) BUG=chromium:579009 LOG=N R=machenbach@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/88c1bc3d564df29ac97d1b2a3b4d1fa4076b359e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -577 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 7 chunks +30 lines, -27 lines 0 comments Download
M src/api-natives.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/api-natives.cc View 7 chunks +110 lines, -110 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/builtins.cc View 3 chunks +9 lines, -20 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/conversions-inl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 4 chunks +6 lines, -7 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 17 chunks +38 lines, -39 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 9 chunks +95 lines, -335 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Michael Hablich
4 years, 10 months ago (2016-02-03 12:26:41 UTC) #1
Michael Hablich
4 years, 10 months ago (2016-02-03 12:27:39 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
88c1bc3d564df29ac97d1b2a3b4d1fa4076b359e.

Powered by Google App Engine
This is Rietveld 408576698