Add very simple test list for chromium_trybot recipe to the chromium tree

Add very simple test list for chromium_trybot recipe to the chromium tree

This will allow changing, adding, and removing tests without two-sided
patches.

The list format can be extended in the future, for now keeping it as simple
and static as possible.

BUG=332239
R=darin@chromium.org, iannucci@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252050

[darin (slow to review), 2014-02-15 03:25:20]

On 2014/02/14 22:32:32, Paweł Hajdan Jr. wrote:

The OWNERS file change seems unrelated. The other change LGTM!

[iannucci, 2014-02-19 00:06:01]

looks like the owners change isn't a change per se, but just adding it as a new
file.

Paweł, what's your planned naming convention for these files? Should there be a
README to say what these files mean or what uses them?

[Paweł Hajdan Jr., 2014-02-19 00:22:18]

On 2014/02/19 00:06:01, iannucci wrote:
> looks like the owners change isn't a change per se, but just adding it as a
new
> file.
> 
> Paweł, what's your planned naming convention for these files? Should there be
a
> README to say what these files mean or what uses them?

For the build bots I plan to use master name, e.g. master.chromium.linux.json
(or just chromium.linux.json).

The current trybot recipe design led to chromium_trybot.json for now, but this
is really quite experimental now.

After some usage and more clients we'll see what people really use and need.

[iannucci, 2014-02-19 00:27:33]

On 2014/02/19 00:22:18, Paweł Hajdan Jr. wrote:
> On 2014/02/19 00:06:01, iannucci wrote:
> > looks like the owners change isn't a change per se, but just adding it as a
> new
> > file.
> > 
> > Paweł, what's your planned naming convention for these files? Should there
be
> a
> > README to say what these files mean or what uses them?
> 
> For the build bots I plan to use master name, e.g. master.chromium.linux.json
> (or just chromium.linux.json).
> 
> The current trybot recipe design led to chromium_trybot.json for now, but this
> is really quite experimental now.
> 
> After some usage and more clients we'll see what people really use and need.

So, to clarify, the 'current scheme' is <recipe_name>.json ?

if so, lgtm 'for now'. Just wanted to have that written down somewhere. Could
you at least doc in the description/commit message?

[Paweł Hajdan Jr., 2014-02-19 19:46:36]

On 2014/02/19 00:27:33, iannucci wrote:
> On 2014/02/19 00:22:18, Paweł Hajdan Jr. wrote:
> > On 2014/02/19 00:06:01, iannucci wrote:
> > > looks like the owners change isn't a change per se, but just adding it as
a
> > new
> > > file.
> > > 
> > > Paweł, what's your planned naming convention for these files? Should there
> be
> > a
> > > README to say what these files mean or what uses them?
> > 
> > For the build bots I plan to use master name, e.g.
master.chromium.linux.json
> > (or just chromium.linux.json).
> > 
> > The current trybot recipe design led to chromium_trybot.json for now, but
this
> > is really quite experimental now.
> > 
> > After some usage and more clients we'll see what people really use and need.
> 
> So, to clarify, the 'current scheme' is <recipe_name>.json ?

This is probably just for chromium_trybot.json, for chromium recipe I'm thinking
about one file per master, e.g. master.chromium.linux.json . We'll see what
works - it's all very easy to change, and for now I'm keeping it simple and not
committing to any particular naming scheme or specific design.

> if so, lgtm 'for now'. Just wanted to have that written down somewhere. Could
> you at least doc in the description/commit message?

Thanks. Please see "The list format can be extended in the future, for now
keeping it as simple 
and static as possible." in the commit message. I'd prefer not to create
expectation that there is any particular naming scheme for now.

In fact, I'd like to create an expectation that all of this is subject to
change. The only factor for now IMHO should be not breaking the bots (which is
possible).

[Paweł Hajdan Jr., 2014-02-19 19:47:44]

Committed patchset #1 manually as r252050 (presubmit successful).

[cmp_google, 2014-02-22 10:18:27]

Pawel, we worked out the vision here 6 mos ago to use src/build/slave to
house files exactly like this.  Can you talk to stip@ to at least get that
context?

'Buildbot' is likely to be a regrettabld naming choice.  Testing/build is
more futureproof.  Please rename this directory to that before the name
becomes more entrenched and impossible to change.

Can you confirm this work does not directly impact the work to switch the
CQ to use presubmit.py?  Mike had been working on that and we must be sure
that you and he are planning all of these ideas out together.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[iannucci, 2014-02-22 19:17:40]

[Agree with buildbot being not a great choice long-term, but it shouldn't
be hard to change.]


On Sat, Feb 22, 2014 at 2:18 AM, Chase Phillips <cmp@google.com> wrote:

> Pawel, we worked out the vision here 6 mos ago to use src/build/slave to
> house files exactly like this.  Can you talk to stip@ to at least get
> that context?
>
> 'Buildbot' is likely to be a regrettabld naming choice.  Testing/build is
> more futureproof.  Please rename this directory to that before the name
> becomes more entrenched and impossible to change.
>
> Can you confirm this work does not directly impact the work to switch the
> CQ to use presubmit.py?  Mike had been working on that and we must be sure
> that you and he are planning all of these ideas out together.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Paweł, 2014-04-01 14:57:35]

Just to follow up here, I'll be working on the consistent presubmit/cq
unified support.

IMHO buildbot is fine - this format really is buildbot-specific (builder
names, waterfalls), and when we have something new it'd need to look
different from this.

Obviously further discussion is fine, just wanted to share my thoughts on
this, and will do remaining work here.

Paweł


On Sat, Feb 22, 2014 at 8:17 PM, Robert Iannucci <iannucci@chromium.org>wrote:

> [Agree with buildbot being not a great choice long-term, but it shouldn't
> be hard to change.]
>
>
> On Sat, Feb 22, 2014 at 2:18 AM, Chase Phillips <cmp@google.com> wrote:
>
>> Pawel, we worked out the vision here 6 mos ago to use src/build/slave to
>> house files exactly like this.  Can you talk to stip@ to at least get
>> that context?
>>
>> 'Buildbot' is likely to be a regrettabld naming choice.  Testing/build is
>> more futureproof.  Please rename this directory to that before the name
>> becomes more entrenched and impossible to change.
>>
>> Can you confirm this work does not directly impact the work to switch the
>> CQ to use presubmit.py?  Mike had been working on that and we must be sure
>> that you and he are planning all of these ideas out together.
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.