|
|
Created:
6 years, 10 months ago by Manuel Rego Modified:
6 years, 10 months ago CC:
chromium-reviews, Diego Pino, svillar, Dirk Pranke, dglazkov, abarth-chromium, Daniel Berlin Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionAdd Igalia to AUTHORS file
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253127
Patch Set 1 #Patch Set 2 : Fixing order of new entry in AUTHORS file (my mistake in previous patch sorry) #Messages
Total messages: 23 (0 generated)
Igalia is a Chromium/Blink contributor. As agreed in blink-dev the new short-license header is used in new files in Blink, so Igalia should be included in AUTHORS file. Adding a wildcard rule as we have several people working on it.
I'm not exactly sure how this works. Igalia is a corporate CLA signer, but has a specific list of contributors. I guess this rule is fine, but we still need to check the individual contributors against the CLA since we don't have a blanket rule there? I'm not sure who would know how this works?
Looking at the other *@foo.com rules in AUTHORS and comparing with the CLA corporate signers, it appears that only the ones which are using the "all members" rule use this pattern. Looks like others which have an explicit list of allowed authors (like samsung and igalia) list them out in AUTHORS directly. Again, someone else may understand this all better than I... It's very silly that this is all manually enforced instead of via some script.
On 2014/02/14 12:09:54, eseidel wrote: > Igalia is a corporate CLA signer, but has a specific list of contributors. I > guess this rule is fine, but we still need to check the individual contributors > against the CLA since we don't have a blanket rule there? Maybe it would be simpler to add use "all members" for Igalia CLA. We didn't know it was possible. svillar is the one usually managing changes in the CLA. I'm not sure what's needed to do that change though.
+dannyb ... Danniel, can you help us out here?
sigh, Daniel, not Danniel :).
So, if you want all Igalia employees to be authorized, just have the person who signed/authorized the CLA email me (dannyb@google.com) and let me know that, and I will update the entry in our files.
On 2014/02/14 21:23:30, Daniel Berlin wrote: > So, if you want all Igalia employees to be authorized, just have the person who > signed/authorized the CLA email me (mailto:dannyb@google.com) and let me know that, and > I will update the entry in our files. Ok, thank you very much. We'll do it. Once everything is ready from the CLA point of view, I'll notify here and this change might be committed.
On 2014/02/14 21:27:40, Manuel Rego wrote: > On 2014/02/14 21:23:30, Daniel Berlin wrote: > > So, if you want all Igalia employees to be authorized, just have the person > who > > signed/authorized the CLA email me (mailto:dannyb@google.com) and let me know > that, and > > I will update the entry in our files. > > Ok, thank you very much. We'll do it. > > Once everything is ready from the CLA point of view, I'll notify here and this > change might be > committed. svillar has already talked to dannyb and Igalia CLA has been updated. So, I guess now this change can be committed.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/166663002/50001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/166663002/50001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/166663002/50001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/166663002/50001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/166663002/50001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/166663002/50001
Message was sent while issue was closed.
Change committed as 253127 |