Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js

Issue 1666623006: MD Settings: Manage search engines 3/3, hooking up UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manage_search_engines_handler
Patch Set: Resolving conflicts with ToT Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js b/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js
index 6e7bc928e02d5f01bb2e70faced737c9c3a86225..dbb705c3451de286503b65546bd52865f7f2dbc8 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js
@@ -35,56 +35,84 @@ var SearchEngine;
var SearchEnginesInfo;
cr.define('settings', function() {
- /** @constructor */
- function SearchEnginesBrowserProxy() {};
+ /** @interface */
+ function SearchEnginesBrowserProxy() {}
+ SearchEnginesBrowserProxy.prototype = {
+ /** @param {number} modelIndex */
+ setDefaultSearchEngine: function(modelIndex) {},
+
+ /** @param {number} modelIndex */
+ removeSearchEngine: function(modelIndex) {},
+
+ /** @param {number} modelIndex */
+ searchEngineEditStarted: function(modelIndex) {},
+
+ searchEngineEditCancelled: function() {},
+
+ /**
+ * @param {string} searchEngine
+ * @param {string} keyword
+ * @param {string} queryUrl
+ */
+ searchEngineEditCompleted: function(searchEngine, keyword, queryUrl) {},
+
+ /**
+ * @return {!Promise<!SearchEnginesInfo>}
+ */
+ getSearchEnginesList: function() {},
+
+ /**
+ * @param {string} fieldName
+ * @param {string} fieldValue
+ * @return {!Promise<boolean>}
+ */
+ validateSearchEngineInput: function(fieldName, fieldValue) {},
+ };
+
+ /**
+ * @constructor
+ * @implements {settings.SearchEnginesBrowserProxy}
+ */
+ function SearchEnginesBrowserProxyImpl() {}
// The singleton instance_ is replaced with a test version of this wrapper
// during testing.
- cr.addSingletonGetter(SearchEnginesBrowserProxy);
+ cr.addSingletonGetter(SearchEnginesBrowserProxyImpl);
- SearchEnginesBrowserProxy.prototype = {
- /** @param {number} modelIndex */
+ SearchEnginesBrowserProxyImpl.prototype = {
+ /** @override */
setDefaultSearchEngine: function(modelIndex) {
chrome.send('setDefaultSearchEngine', [modelIndex]);
},
- /** @param {number} modelIndex */
+ /** @override */
removeSearchEngine: function(modelIndex) {
chrome.send('removeSearchEngine', [modelIndex]);
},
- /** @param {number} modelIndex */
+ /** @override */
searchEngineEditStarted: function(modelIndex) {
chrome.send('searchEngineEditStarted', [modelIndex]);
},
+ /** @override */
searchEngineEditCancelled: function() {
chrome.send('searchEngineEditCancelled');
},
- /**
- * @param {string} searchEngine
- * @param {string} keyword
- * @param {string} queryUrl
- */
+ /** @override */
searchEngineEditCompleted: function(searchEngine, keyword, queryUrl) {
chrome.send('searchEngineEditCompleted', [
searchEngine, keyword, queryUrl,
]);
},
- /**
- * @return {!Promise<!SearchEnginesInfo>}
- */
+ /** @override */
getSearchEnginesList: function() {
return cr.sendWithPromise('getSearchEnginesList');
},
- /**
- * @param {string} fieldName
- * @param {string} fieldValue
- * @return {!Promise<boolean>}
- */
+ /** @override */
validateSearchEngineInput: function(fieldName, fieldValue) {
return cr.sendWithPromise(
'validateSearchEngineInput', fieldName, fieldValue);
@@ -92,6 +120,6 @@ cr.define('settings', function() {
};
return {
- SearchEnginesBrowserProxy: SearchEnginesBrowserProxy,
+ SearchEnginesBrowserProxyImpl: SearchEnginesBrowserProxyImpl,
};
});

Powered by Google App Engine
This is Rietveld 408576698