Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3862)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 1666623006: MD Settings: Manage search engines 3/3, hooking up UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manage_search_engines_handler
Patch Set: Resolving conflicts with ToT Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
index f25513d5f9ae094ce2bf81628aa4f477a86b0c82..9e840ab83224638bcb409f146c2121a0886e097f 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
@@ -14,23 +14,48 @@ Polymer({
properties: {
/** @type {!SearchEngine} */
- engine: Object
+ engine: Object,
+
+ /** @private {boolean} */
+ showEditSearchEngineDialog_: Boolean,
+ },
+
+ /** @private {!settings.SearchEnginesBrowserProxy} */
+ browserProxy_: null,
+
+ created: function() {
+ this.browserProxy_ = settings.SearchEnginesBrowserProxyImpl.getInstance();
},
/** @private */
onDeleteTap_: function() {
- chrome.searchEnginesPrivate.removeSearchEngine(this.engine.guid);
+ this.browserProxy_.removeSearchEngine(this.engine.modelIndex);
},
/** @private */
onEditTap_: function() {
- // TODO(dpapad): Implement edit mode.
+ this.closePopupMenu_();
+
+ this.showEditSearchEngineDialog_ = true;
+ this.async(function() {
+ var dialog = this.$$('settings-search-engine-dialog');
+ // Register listener to detect when the dialog is closed. Flip the boolean
+ // once closed to force a restamp next time it is shown such that the
+ // previous dialog's contents are cleared.
+ dialog.addEventListener('iron-overlay-closed', function() {
+ this.showEditSearchEngineDialog_ = false;
+ }.bind(this));
+ }.bind(this));
},
/** @private */
onMakeDefaultTap_: function() {
- chrome.searchEnginesPrivate.setSelectedSearchEngine(this.engine.guid);
- var popupMenu = this.$$('iron-dropdown');
- popupMenu.close();
+ this.closePopupMenu_();
+ this.browserProxy_.setDefaultSearchEngine(this.engine.modelIndex);
+ },
+
+ /** @private */
+ closePopupMenu_: function() {
+ this.$$('iron-dropdown').close();
},
});

Powered by Google App Engine
This is Rietveld 408576698