chrome/test/data/webui/settings/cr_settings_browsertest.js - Issue 1666623006: MD Settings: Manage search engines 3/3, hooking up UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/cr_settings_browsertest.js

Issue 1666623006: MD Settings: Manage search engines 3/3, hooking up UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manage_search_engines_handler

Patch Set: undo accidental binding conversion to one-way Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/search_engines_page/search_engines_page.js ('K') | « chrome/browser/resources/settings/settings_resources.grd ('k') | chrome/test/data/webui/settings/search_engines_page_test.js » ('j') | chrome/test/data/webui/settings/search_engines_page_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/cr_settings_browsertest.js

diff --git a/chrome/test/data/webui/settings/cr_settings_browsertest.js b/chrome/test/data/webui/settings/cr_settings_browsertest.js

index 6790547a46ce942fbbbcf6073391fe7cf4773692..9f57c7b6ac58cee140aa11acaa4a94a5c95730cf 100644

--- a/chrome/test/data/webui/settings/cr_settings_browsertest.js

+++ b/chrome/test/data/webui/settings/cr_settings_browsertest.js

@@ -36,6 +36,7 @@ CrSettingsBrowserTest.prototype = {

'prefs_test_cases.js',

'prefs_tests.js',

'reset_page_test.js',

+ 'search_engines_page_test.js',

Dan Beam 2016/02/18 03:08:19 please derive CrSettingsBrowserTest instead of doi

dpapad 2016/02/18 19:34:51 Done.

'site_details_tests.js',

'site_details_permission_tests.js',

'site_list_tests.js',

@@ -69,9 +70,15 @@ TEST_F('CrSettingsBrowserTest', 'MAYBE_CrSettingsTest', function() {

mocha.run();

});

TEST_F('CrSettingsBrowserTest', 'ResetPage', function() {

settings_reset_page.registerDialogTests();

settings_reset_page.registerBannerTests();

mocha.run();

});

+TEST_F('CrSettingsBrowserTest', 'SearchEnginesPage', function() {

+ settings_search_engines_page.registerDialogTests();

+ settings_search_engines_page.registerEntryTests();

+ settings_search_engines_page.registerPageTests();

+ mocha.run();

+});