MD Settings: Manage search engines 3/3, hooking up UI.

chrome/browser/resources/settings/search_engines_page/search_engines_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-search-engines-page' is the settings page
  * containing search engines settings.
- *
- * Example:
- *
- *    <core-animated-pages>
- *      <settings-search-engines-page prefs="{{prefs}}">
- *      </settings-search-engines-page>
- *      ... other pages ...
- *    </core-animated-pages>
- *
+ */
+
+/**

[Dan Beam, 2016/02/17 02:21:35]

can you keep these 2 comments joined like they were (even if you remove the
example boilerplate)?

[Dan Beam, 2016/02/18 03:08:18]

ping

[dpapad, 2016/02/18 19:34:51]

Done.

  * @group Chrome Settings Elements
  * @element settings-search-engines-page
  */
 Polymer({
   is: 'settings-search-engines-page',
 
   properties: {
     /** @type {!Array<!SearchEngine>} */
     defaultEngines: {
       type: Array,
       value: function() { return []; }
     },
 
     /** @type {!Array<!SearchEngine>} */
     otherEngines: {
       type: Array,
       value: function() { return []; }
     },
 
     /** @type {boolean} */
-    showAddSearchEngineDialog_: {
+    showAddSearchEngineDialog_: Boolean,
+
+    /** @type {boolean} */
+    otherSearchEnginesExpanded_: {
       type: Boolean,
-      value: false,
+      value: true,
     },
   },
 
+  /**
+   * Holds WebUI listeners that need to be removed when this element is
+   * destroyed.
+   * TODO(dpapad): Move listener tracking logic to a Polymer behavior class,
+   * such that it can be re-used.
+   * @private {!Array<!WebUIListener>}
+   */
+  webUIListeners_: [],
+
   /** @override */
   ready: function() {
-    chrome.searchEnginesPrivate.onSearchEnginesChanged.addListener(
-        this.enginesChanged_.bind(this));
-    this.enginesChanged_();
+    settings.SearchEnginesBrowserProxy.getInstance().
+        getSearchEnginesList().then(this.enginesChanged_.bind(this));
+    this.webUIListeners_.push(
+        cr.addWebUIListener(
+            'search-engines-changed',
+            this.enginesChanged_.bind(this)));
+  },
+
+  /** @override */
+  detached: function() {
+    this.webUIListeners_.forEach(function(listener) {
+      cr.removeWebUIListener(listener);
+    });
   },
 
   /** @private */

[Dan Beam, 2016/02/17 02:21:35]

can you document |searchEnginesInfo| and its @type?

[dpapad, 2016/02/17 03:22:36]

Done. The typedef is already defined (see search_engines_browser_proxy.js), but
had forgotten to type the annotation here.

-  enginesChanged_: function() {
-    chrome.searchEnginesPrivate.getSearchEngines(function(engines) {
-      this.defaultEngines = engines.filter(function(engine) {
-        return engine.type ==
-            chrome.searchEnginesPrivate.SearchEngineType.DEFAULT;
-      }, this);
-
-      this.otherEngines = engines.filter(function(engine) {
-        return engine.type ==
-            chrome.searchEnginesPrivate.SearchEngineType.OTHER;
-      }, this);
-    }.bind(this));
+  enginesChanged_: function(searchEnginesInfo) {
+    this.defaultEngines = searchEnginesInfo['defaults'];
+    this.otherEngines = searchEnginesInfo['others'];
+    // TODO(dpapad): Use searchEnginesInfo['extensions'] once UI mocks are
+    // provided.
   },
 
   /** @private */
   onAddSearchEngineTap_: function() {
     this.showAddSearchEngineDialog_ = true;
     this.async(function() {
-      var dialog = this.$$('settings-add-search-engine-dialog');
+      var dialog = this.$$('settings-search-engine-dialog');
       // Register listener to detect when the dialog is closed. Flip the boolean
       // once closed to force a restamp next time it is shown such that the
       // previous dialog's contents are cleared.
       dialog.addEventListener('iron-overlay-closed', function() {
         this.showAddSearchEngineDialog_ = false;
       }.bind(this));
-      dialog.open();
     }.bind(this));
   },
 });