Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1666613002: Remove APPLE_ARMV7S-specific code from Blink. (Closed)

Created:
4 years, 10 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 10 months ago
Reviewers:
haraken, esprehn
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, kinuko+watch, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove APPLE_ARMV7S-specific code from Blink. Blink includes some code that is specific to the ARMv7s architecture, intended for Apple devices, that predates the fork from WebKit. Blink is not built for iOS devices and this code path is not tested. This patch removes all references to the "CPU(APPLE_ARMV7S)" macro (and equivalent "WTF_CPU_APPLE_ARMV7S") from the code, along with all code gated by this macro. It does not, however, remove other references to "defined(__ARM_ARCH_7S__)". For more background, see https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z_ZPn1_Q5Z0/discussion BUG=477892 Committed: https://crrev.com/0a3a4c9dfb3d7a54ff0fc47da4a00e60d49cee9c Cr-Commit-Position: refs/heads/master@{#373393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -108 lines) Patch
M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
M third_party/WebKit/Source/wtf/CPU.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
suzyh_UTC10 (ex-contributor)
4 years, 10 months ago (2016-02-03 05:48:22 UTC) #2
esprehn
Lgtm, thanks!
4 years, 10 months ago (2016-02-03 06:46:30 UTC) #3
suzyh_UTC10 (ex-contributor)
+haraken, particularly for OWNERS approval for wtf/CPU.h.
4 years, 10 months ago (2016-02-03 22:50:29 UTC) #5
haraken
wtf/ LGTM
4 years, 10 months ago (2016-02-03 23:31:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666613002/1
4 years, 10 months ago (2016-02-03 23:38:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 00:00:06 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 00:01:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a3a4c9dfb3d7a54ff0fc47da4a00e60d49cee9c
Cr-Commit-Position: refs/heads/master@{#373393}

Powered by Google App Engine
This is Rietveld 408576698