Add --output-directory flag to build/android/asan_symbolize.py

Add --output-directory flag to build/android/asan_symbolize.py

BUG=573345
Committed: https://crrev.com/2ef8a36bee16d8f64e30b9a67979a1ddf2484a8f
Cr-Commit-Position: refs/heads/master@{#373832}

[agrieve, 2016-02-03 03:10:53]

Description was changed from

==========
Add --output-directory flag to build/android/asan_symbolize.py

It is always required, unless CHROMIUM_OUTPUT_DIR or CHROMIUM_OUT_DIR are set or
when the current working directory is an output directory (contains a
build.ninja file)

BUG=573345
==========

to

==========
Add --output-directory flag to build/android/asan_symbolize.py

It is always required, unless CHROMIUM_OUTPUT_DIR or CHROMIUM_OUT_DIR are set or
when the current working directory is an output directory (contains a
build.ninja file)

BUG=573345
==========

[agrieve, 2016-02-03 03:10:53]

agrieve@chromium.org changed reviewers:
+ pasko@chromium.org

[agrieve, 2016-02-03 03:11:10]

On 2016/02/03 03:10:53, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pasko@chromium.org

▬▬▬▬▬▬▬▬

[pasko, 2016-02-03 10:16:10]

lgtm with a suggestion

[pasko, 2016-02-03 10:16:25]

the suggestion :)

https://codereview.chromium.org/1666593002/diff/20001/build/android/asan_symb...
File build/android/asan_symbolize.py (right):

https://codereview.chromium.org/1666593002/diff/20001/build/android/asan_symb...
build/android/asan_symbolize.py:97: parser.add_option('--output-directory',
Plz add --out-dir as an alias for consistency with other scripts.

[agrieve, 2016-02-03 21:22:49]

On 2016/02/03 10:16:25, pasko wrote:
> the suggestion :)
> 
>
https://codereview.chromium.org/1666593002/diff/20001/build/android/asan_symb...
> File build/android/asan_symbolize.py (right):
> 
>
https://codereview.chromium.org/1666593002/diff/20001/build/android/asan_symb...
> build/android/asan_symbolize.py:97: parser.add_option('--output-directory',
> Plz add --out-dir as an alias for consistency with other scripts.

--out-dir (at least in adb_gdb) = "out/", as opposed to --output-directory,
which is "out/Debug".
Same distinction with CHROMIUM_OUT_DIR vs CHROMIUM_OUTPUT_DIR.

[pasko, 2016-02-04 12:23:36]

On 2016/02/03 21:22:49, agrieve wrote:
> On 2016/02/03 10:16:25, pasko wrote:
> > the suggestion :)
> > 
> >
>
https://codereview.chromium.org/1666593002/diff/20001/build/android/asan_symb...
> > File build/android/asan_symbolize.py (right):
> > 
> >
>
https://codereview.chromium.org/1666593002/diff/20001/build/android/asan_symb...
> > build/android/asan_symbolize.py:97: parser.add_option('--output-directory',
> > Plz add --out-dir as an alias for consistency with other scripts.
> 
> --out-dir (at least in adb_gdb) = "out/", as opposed to --output-directory,
> which is "out/Debug".
> Same distinction with CHROMIUM_OUT_DIR vs CHROMIUM_OUTPUT_DIR.

ah, right! still, shall we have both variants for all scripts?

[agrieve, 2016-02-04 18:36:52]

On 2016/02/04 12:23:36, pasko (OOO through 2016-02-19) wrote:
> On 2016/02/03 21:22:49, agrieve wrote:
> > On 2016/02/03 10:16:25, pasko wrote:
> > > the suggestion :)
> > > 
> > >
> >
>
https://codereview.chromium.org/1666593002/diff/20001/build/android/asan_symb...
> > > File build/android/asan_symbolize.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1666593002/diff/20001/build/android/asan_symb...
> > > build/android/asan_symbolize.py:97:
parser.add_option('--output-directory',
> > > Plz add --out-dir as an alias for consistency with other scripts.
> > 
> > --out-dir (at least in adb_gdb) = "out/", as opposed to --output-directory,
> > which is "out/Debug".
> > Same distinction with CHROMIUM_OUT_DIR vs CHROMIUM_OUTPUT_DIR.
> 
> ah, right! still, shall we have both variants for all scripts?

I think the goal should be to get rid of CHROMIUM_OUT_DIR. I think it adds more
confusion than value.

[agrieve, 2016-02-05 15:37:26]

Description was changed from

==========
Add --output-directory flag to build/android/asan_symbolize.py

It is always required, unless CHROMIUM_OUTPUT_DIR or CHROMIUM_OUT_DIR are set or
when the current working directory is an output directory (contains a
build.ninja file)

BUG=573345
==========

to

==========
Add --output-directory flag to build/android/asan_symbolize.py

BUG=573345
==========

[agrieve, 2016-02-05 15:38:26]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-02-05 15:38:27]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1666593002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-05 15:39:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1666593002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1666593002/120001

[commit-bot: I haz the power, 2016-02-05 16:58:37]

Description was changed from

==========
Add --output-directory flag to build/android/asan_symbolize.py

BUG=573345
==========

to

==========
Add --output-directory flag to build/android/asan_symbolize.py

BUG=573345
==========

[commit-bot: I haz the power, 2016-02-05 16:58:38]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-02-05 17:00:02]

Description was changed from

==========
Add --output-directory flag to build/android/asan_symbolize.py

BUG=573345
==========

to

==========
Add --output-directory flag to build/android/asan_symbolize.py

BUG=573345

Committed: https://crrev.com/2ef8a36bee16d8f64e30b9a67979a1ddf2484a8f
Cr-Commit-Position: refs/heads/master@{#373832}
==========

[commit-bot: I haz the power, 2016-02-05 17:00:02]

Patchset 7 (id:??) landed as
https://crrev.com/2ef8a36bee16d8f64e30b9a67979a1ddf2484a8f
Cr-Commit-Position: refs/heads/master@{#373832}