Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1666583002: Use SkTLazy for ScopedDecodedImageLock's optional paint (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, reed1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SkTLazy for ScopedDecodedImageLock's optional paint Minor cleanup: SkTLazy is a nice idiom to avoid explicit ptr + obj tracking for optional paints. R=vmpstr@chromium.org,enne@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/80f3f249da0407f648c0d748526a0a3981e09fe5 Cr-Commit-Position: refs/heads/master@{#373348}

Patch Set 1 #

Total comments: 2

Patch Set 2 : todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M cc/playback/display_list_raster_source.cc View 1 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
f(malita)
4 years, 10 months ago (2016-02-03 04:11:57 UTC) #3
vmpstr
lgtm https://codereview.chromium.org/1666583002/diff/1/cc/playback/display_list_raster_source.cc File cc/playback/display_list_raster_source.cc (right): https://codereview.chromium.org/1666583002/diff/1/cc/playback/display_list_raster_source.cc#newcode179 cc/playback/display_list_raster_source.cc:179: SkTLazy<SkPaint> decoded_paint_; nit: Can you add a TODO ...
4 years, 10 months ago (2016-02-03 19:30:59 UTC) #4
f(malita)
https://codereview.chromium.org/1666583002/diff/1/cc/playback/display_list_raster_source.cc File cc/playback/display_list_raster_source.cc (right): https://codereview.chromium.org/1666583002/diff/1/cc/playback/display_list_raster_source.cc#newcode179 cc/playback/display_list_raster_source.cc:179: SkTLazy<SkPaint> decoded_paint_; On 2016/02/03 19:30:59, vmpstr wrote: > nit: ...
4 years, 10 months ago (2016-02-03 20:34:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666583002/20001
4 years, 10 months ago (2016-02-03 20:35:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 21:48:34 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 21:49:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80f3f249da0407f648c0d748526a0a3981e09fe5
Cr-Commit-Position: refs/heads/master@{#373348}

Powered by Google App Engine
This is Rietveld 408576698