Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1666573006: Hooks for injecting embedder resolver providers. (Closed)

Created:
4 years, 10 months ago by pquitslund
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -30 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 6 chunks +29 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +14 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +8 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 4 chunks +5 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/starter.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 8 chunks +23 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analyzer/lib/plugin/embedded_resolver_provider.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 3 chunks +20 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/starter.dart View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
4 years, 10 months ago (2016-02-03 22:52:54 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-03 23:17:46 UTC) #3
pquitslund
4 years, 10 months ago (2016-02-04 19:03:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37767eff868a10cef322592f6f6a1b57c4cc2a4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698