third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js ('K') | « third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileDataGrid.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

index 9fcbd6067dfd27694913667575172643b508dcb6..ca4db971d1f30027f950a3090f90442386e16156 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

@@ -229,7 +229,7 @@ WebInspector.CPUFlameChartDataProvider.prototype = {

var totalTime = this._millisecondsToString(timelineData.entryTotalTimes[entryIndex]);

pushEntryInfoRow(WebInspector.UIString("Self time"), selfTime);

pushEntryInfoRow(WebInspector.UIString("Total time"), totalTime);

- var callFrame = /** @type {!ConsoleAgent.CallFrame} */ (node);

+ var callFrame = /** @type {!RuntimeAgent.CallFrame} */ (node);

var text = (new WebInspector.Linkifier()).linkifyConsoleCallFrame(this._target, callFrame).textContent;

pushEntryInfoRow(WebInspector.UIString("URL"), text);

pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.secondsToString(node.selfTime / 1000, true));