third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp ('K') | « third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

index 497a32436d2637522f1b6347d91ae1868e6503a5..7debe518e67eff4ffa9d9fc5000338e9bc0aaa94 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

@@ -337,7 +337,7 @@ PassRefPtr<TypeBuilder::Runtime::ExceptionDetails> V8RuntimeAgentImpl::createExc

exceptionDetails->setColumn(message->GetStartColumn());

v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace();

if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0)

- exceptionDetails->setStackTrace(createScriptCallStack(isolate, messageStackTrace, messageStackTrace->GetFrameCount())->buildInspectorArray());

+ exceptionDetails->setStack(createScriptCallStack(isolate, messageStackTrace, messageStackTrace->GetFrameCount())->buildInspectorObject());

return exceptionDetails.release();

}