third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp ('K') | « third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h ('k') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp » ('j') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

index d1e6774e1565b1415ac884a8a49316a29904d408..9d226e776cba232d5a31efc0cc4dc2ce84393a33 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

@@ -30,7 +30,7 @@ class InjectedScriptManager;

class JavaScriptCallFrame;

class JSONObject;

class RemoteCallFrameId;

-class ScriptAsyncCallStack;

+class ScriptCallStack;

class ScriptRegexp;

class V8AsyncCallTracker;

@@ -125,7 +125,7 @@ public:

void removeBreakpoint(const String& scriptId, int lineNumber, int columnNumber, BreakpointSource) override;

// Async call stacks implementation

- PassRefPtr<ScriptAsyncCallStack> currentAsyncStackTraceForConsole() override;

+ PassRefPtr<ScriptCallStack> currentAsyncStackTraceForConsole() override;

int traceAsyncOperationStarting(const String& description) override;

void traceAsyncCallbackStarting(int operationId) override;

void traceAsyncCallbackCompleted() override;