third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/resources/stacktrace-test.js ('k') | third_party/WebKit/LayoutTests/inspector/extensions/extensions-reload.html » ('j') | third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html

diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html b/third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html

index eab0a7a5ad868837b64660208649ae32c3c59a96..79980157e2609d05b2ef6708f7b7bd97365d5204 100644

--- a/third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html

+++ b/third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html

@@ -25,11 +25,11 @@ function test()

var message = uiMessage.consoleMessage();

var stackTrace = message.stackTrace;

- if (stackTrace.length < 3) {

+ if (stackTrace.callFrames.length < 3) {

InspectorTest.addResult('FAILED: Stack size too small');

} else {

for (var i = 0; i < 3; ++i) {

- var frame = stackTrace[i];

+ var frame = stackTrace.callFrames[i];

InspectorTest.addResult('call frame:' + frame.functionName + ' at ' + frame.url + ':' + frame.lineNumber);

}