third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-document-initiator.html » ('j') | third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

index cea8d4fe64a58ff68207dfd9b8c0504650cb525c..cb75b17809c2294624b5230ed0169d279d4ad9da 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

@@ -47,7 +47,7 @@ InspectorTest.prepareConsoleMessageText = function(messageElement, consoleMessag

// Strip out InjectedScript line numbers from stack traces to avoid rebaselining each time InjectedScriptSource is edited.

messageText = messageText.replace(/InjectedScript\.\w+ @ VM:\d+/g, "");

// Strip out InjectedScript line numbers from console message anchor.

- var functionName = consoleMessage && consoleMessage.stackTrace && consoleMessage.stackTrace[0] && consoleMessage.stackTrace[0].functionName || "";

+ var functionName = consoleMessage && consoleMessage.stackTrace && consoleMessage.stackTrace.callFrames[0] && consoleMessage.stackTrace.callFrames[0].functionName || "";

if (functionName.indexOf("InjectedScript") !== -1)

messageText = messageText.replace(/\bVM:\d+/, ""); // Only first replace.

if (messageText.startsWith("Navigated to")) {