Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: testts Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Ass ert) { 275 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Ass ert) {
276 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on assertion.")); 276 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on assertion."));
277 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.CSP Violation) { 277 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.CSP Violation) {
278 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a script blocked due to Content Security Policy directive: \"%s\".", details. auxData["directiveText"])); 278 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a script blocked due to Content Security Policy directive: \"%s\".", details. auxData["directiveText"]));
279 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Deb ugCommand) { 279 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Deb ugCommand) {
280 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a debugged function.")); 280 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a debugged function."));
281 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Asy ncOperation) { 281 } else if (details.reason === WebInspector.DebuggerModel.BreakReason.Asy ncOperation) {
282 if (Runtime.experiments.isEnabled("stepIntoAsync")) { 282 if (Runtime.experiments.isEnabled("stepIntoAsync")) {
283 var operationId = details.auxData["operationId"]; 283 var operationId = details.auxData["operationId"];
284 var operation = this.sidebarPanes.asyncOperationBreakpoints.oper ationById(details.target(), operationId); 284 var operation = this.sidebarPanes.asyncOperationBreakpoints.oper ationById(details.target(), operationId);
285 var description = (operation && operation.description) || WebIns pector.UIString("<unknown>"); 285 var description = (operation && operation.stack && operation.sta ck.description) || WebInspector.UIString("<unknown>");
286 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Pau sed on a \"%s\" async operation.", description)); 286 this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Pau sed on a \"%s\" async operation.", description));
287 this.sidebarPanes.asyncOperationBreakpoints.highlightBreakpoint( operationId); 287 this.sidebarPanes.asyncOperationBreakpoints.highlightBreakpoint( operationId);
288 } 288 }
289 } else { 289 } else {
290 if (details.callFrames.length) 290 if (details.callFrames.length)
291 WebInspector.debuggerWorkspaceBinding.createCallFrameLiveLocatio n(details.callFrames[0], didGetUILocation.bind(this)); 291 WebInspector.debuggerWorkspaceBinding.createCallFrameLiveLocatio n(details.callFrames[0], didGetUILocation.bind(this));
292 else 292 else
293 console.warn("ScriptsPanel paused, but callFrames.length is zero ."); // TODO remove this once we understand this case better 293 console.warn("ScriptsPanel paused, but callFrames.length is zero ."); // TODO remove this once we understand this case better
294 } 294 }
295 295
(...skipping 1123 matching lines...) Expand 10 before | Expand all | Expand 10 after
1419 WebInspector.SourcesPanelFactory.prototype = { 1419 WebInspector.SourcesPanelFactory.prototype = {
1420 /** 1420 /**
1421 * @override 1421 * @override
1422 * @return {!WebInspector.Panel} 1422 * @return {!WebInspector.Panel}
1423 */ 1423 */
1424 createPanel: function() 1424 createPanel: function()
1425 { 1425 {
1426 return WebInspector.SourcesPanel.instance(); 1426 return WebInspector.SourcesPanel.instance();
1427 } 1427 }
1428 } 1428 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698