net/quic/test_tools/quic_packet_creator_peer.cc - Issue 1666553002: Make QUIC's SerializedPacket contain QuicFrames, rather than a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/quic_packet_creator_peer.cc

Issue 1666553002: Make QUIC's SerializedPacket contain QuicFrames, rather than a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@113205205

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/test_tools/quic_packet_creator_peer.cc

diff --git a/net/quic/test_tools/quic_packet_creator_peer.cc b/net/quic/test_tools/quic_packet_creator_peer.cc

index 53a928cbe3ae02118614e15ce9c44b04296d6676..90e469f121a4c5c01861ba7ac0de3bf8cf9f6306 100644

--- a/net/quic/test_tools/quic_packet_creator_peer.cc

+++ b/net/quic/test_tools/quic_packet_creator_peer.cc

@@ -127,7 +127,7 @@ SerializedPacket QuicPacketCreatorPeer::SerializeAllFrames(

SerializedPacket packet = creator->packet_;

// The caller takes ownership of the QuicEncryptedPacket.

creator->packet_.packet = nullptr;

- DCHECK(packet.retransmittable_frames == nullptr);

+ DCHECK(packet.retransmittable_frames.empty());

return packet;

}

« no previous file with comments | « net/quic/quic_utils.cc ('k') | no next file » | no next file with comments »