Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 166653003: api accessor store ics should return passed value (Closed)

Created:
6 years, 10 months ago by dcarney
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

api accessor store ics should return passed value R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19380

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : ia32 #

Patch Set 4 : arm #

Patch Set 5 : a64 #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -58 lines) Patch
M src/a64/code-stubs-a64.cc View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M src/a64/stub-cache-a64.cc View 1 2 3 4 4 chunks +5 lines, -3 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M src/code-stubs.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +3 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 2 chunks +7 lines, -5 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-accessors.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +22 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
PTAL
6 years, 10 months ago (2014-02-14 12:54:08 UTC) #1
Toon Verwaest
lgtm if a64 is added
6 years, 10 months ago (2014-02-14 13:07:11 UTC) #2
dcarney
6 years, 10 months ago (2014-02-14 14:13:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 manually as r19380 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698