[sql] Remove misleading AutoRecoverTable() parameter.

sql/recovery.cc

Index: sql/recovery.cc
diff --git a/sql/recovery.cc b/sql/recovery.cc
index 5e101b1ce3b456d534734cec0c412b527b3153d9..5c4223c024cb650957dc1674762db7494ecb0f68 100644
--- a/sql/recovery.cc
+++ b/sql/recovery.cc
@@ -349,7 +349,6 @@ void Recovery::Shutdown(Recovery::Disposition raze) {
 }
 
 bool Recovery::AutoRecoverTable(const char* table_name,
-                                size_t extend_columns,
                                 size_t* rows_recovered) {
   // Query the info for the recovered table in database [main].
   std::string query(
@@ -459,14 +458,6 @@ bool Recovery::AutoRecoverTable(const char* table_name,
   if (pk_column_count == 1 && !rowid_decl.empty())
     create_column_decls[rowid_ofs] = rowid_decl;
 
-  // Additional columns accept anything.
-  // TODO(shess): ignoreN isn't well namespaced.  But it will fail to
-  // execute in case of conflicts.
-  for (size_t i = 0; i < extend_columns; ++i) {
-    create_column_decls.push_back(
-        base::StringPrintf("ignore%" PRIuS " ANY", i));
-  }

[Scott Hess - ex-Googler, 2016/02/03 20:36:18]

Summary of "why": Recovery works by defining a virtual table over the data of a
real table.  That virtual table allows the regular SQLite case of "row has fewer
columns than expected, return NULL for extras", but if there are more columns
than requested it assumes the row is corrupt.  This code was meant to handle the
fewer-columns-than-requested case, but actually handles the
more-columns-than-requested case.  So it is unnecessary.

[Ryan Hamilton, 2016/02/04 01:36:34]

Cute!

[Scott Hess - ex-Googler, 2016/02/04 18:39:59]

I was prototyping an alternative recovery method which didn't use the virtual
table, and found that in that case I _did_ have to actually implement this, and
that my test which tested that implementation broke this implementation.  It was
embarrassing.

-
   std::string recover_create(base::StringPrintf(
       "CREATE VIRTUAL TABLE temp.recover_%s USING recover(corrupt.%s, %s)",
       table_name,