Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1666433003: Rename SkBitmapProcStateAutoMapper methods (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkBitmapProcStateAutoMapper methods x(),y() -> fractionalIntX(), fractionalIntY() (to clarify the return type) Also add fixed & int helpers. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1666433003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/be5cfa9a9e1cfb77beba27727df7149ab5e7d422

Patch Set 1 #

Patch Set 2 : fixed, int helpers #

Patch Set 3 : neon build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -38 lines) Patch
M src/core/SkBitmapProcState.h View 1 1 chunk +8 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkBitmapProcState_matrix.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmapProcState_matrixProcs.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcState_matrix_template.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmapProcState_shaderproc.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_matrix_neon.h View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSE2.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
f(malita)
4 years, 10 months ago (2016-02-03 16:59:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666433003/1
4 years, 10 months ago (2016-02-03 16:59:11 UTC) #4
reed1
Thanks for experimenting. Probably slightly better, but no biggie I think either way. Another "possible" ...
4 years, 10 months ago (2016-02-03 17:18:21 UTC) #5
f(malita)
On 2016/02/03 17:18:21, reed1 wrote: > Another "possible" clarification could be to embedded the various ...
4 years, 10 months ago (2016-02-03 17:23:49 UTC) #6
f(malita)
On 2016/02/03 17:23:49, f(malita) wrote: > On 2016/02/03 17:18:21, reed1 wrote: > > Another "possible" ...
4 years, 10 months ago (2016-02-03 17:45:08 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666433003/20001
4 years, 10 months ago (2016-02-03 17:45:19 UTC) #10
reed1
lgtm
4 years, 10 months ago (2016-02-03 17:48:15 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/4141)
4 years, 10 months ago (2016-02-03 17:48:33 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666433003/40001
4 years, 10 months ago (2016-02-03 17:50:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666433003/40001
4 years, 10 months ago (2016-02-03 18:15:09 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 18:21:37 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/be5cfa9a9e1cfb77beba27727df7149ab5e7d422

Powered by Google App Engine
This is Rietveld 408576698