Make "git cl format" format GN files.

Make "git cl format" format GN files.

Always formats full GN files that are modified since the format should
be canonical.

I tried to make it consistent in style with the existing formatters. I've
tested running it locally. For "git cl format" it formats GN files. For
"git cl format --diff" it outputs the full formatted files like clang but
doesn't modify. For "git cl format --dry-run" it doesn't modify or output.

TEST=Works running locally.
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298617

[kylechar, 2016-02-04 22:35:09]

Description was changed from

==========
Make "git cl format" format GN files.

Formats all GN files that were modified when running git cl format.

BUG=
==========

to

==========
Make "git cl format" format GN files.

Formats all GN files that were modified when running git cl format.

TEST=Works running locally.
==========

[kylechar, 2016-02-04 22:45:24]

Description was changed from

==========
Make "git cl format" format GN files.

Formats all GN files that were modified when running git cl format.

TEST=Works running locally.
==========

to

==========
Make "git cl format" format GN files.

Always formats full GN files that are modified since the format should
be canonical.

I tried to make it consistent in style with the existing formatters. I've
tested running it locally. For "git cl format" it formats GN files. For
"git cl format --diff" it outputs the full formatted files like clang but
doesn't modify. For "git cl format --dry-run" it doesn't modify or output.

TEST=Works running locally.
BUG=
==========

[kylechar, 2016-02-04 22:46:52]

kylechar@chromium.org changed reviewers:
+ agable@chromium.org, maruel@chromium.org

[kylechar, 2016-02-04 22:53:29]

Here is a CL that adds gn format to git cl format. Since presubmit ends up
complaining about unformatted gn files it seems like this might as well just
happen automatically. I've modeled it on the existing formatters in CMDformat so
hopefully it's suitable.

I've tested it locally on a few files and it seems to work fine. Not sure if
there are tests to run or anything else I need to modify. Thanks!

[agable, 2016-02-04 23:32:57]

lgtm

[kylechar, 2016-02-05 00:07:21]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 00:07:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1666403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1666403002/1

[commit-bot: I haz the power, 2016-02-05 00:09:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 00:09:52]

Dry run: This issue passed the CQ dry run.

[M-A Ruel, 2016-02-05 00:22:19]

maruel@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[M-A Ruel, 2016-02-05 00:22:20]

Please make sure Brett and/or Dirk approve first.

[Dirk Pranke, 2016-02-05 00:26:46]

lgtm

[kylechar, 2016-02-05 13:26:50]

Thanks!

[kylechar, 2016-02-05 13:26:52]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-02-05 13:27:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1666403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1666403002/1

[commit-bot: I haz the power, 2016-02-05 13:28:59]

Description was changed from

==========
Make "git cl format" format GN files.

Always formats full GN files that are modified since the format should
be canonical.

I tried to make it consistent in style with the existing formatters. I've
tested running it locally. For "git cl format" it formats GN files. For
"git cl format --diff" it outputs the full formatted files like clang but
doesn't modify. For "git cl format --dry-run" it doesn't modify or output.

TEST=Works running locally.
BUG=
==========

to

==========
Make "git cl format" format GN files.

Always formats full GN files that are modified since the format should
be canonical.

I tried to make it consistent in style with the existing formatters. I've
tested running it locally. For "git cl format" it formats GN files. For
"git cl format --diff" it outputs the full formatted files like clang but
doesn't modify. For "git cl format --dry-run" it doesn't modify or output.

TEST=Works running locally.
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298617
==========

[commit-bot: I haz the power, 2016-02-05 13:29:00]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298617