[sql] Framework for allowing tests to handle errors.

sql/connection.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SQL_CONNECTION_H_
 #define SQL_CONNECTION_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 521 matching lines @@
   // This object handles errors resulting from all forms of executing sqlite
   // commands or statements. It can be null which means default handling.
   scoped_ptr<ErrorDelegate> error_delegate_;
 
   // Tag for auxiliary histograms.
   std::string histogram_tag_;
 
   DISALLOW_COPY_AND_ASSIGN(Connection);
 };
 
+// Most errors are fatal in debug mode, because usually they indicate
+// an inappropriate use of SQL.  This makes it challenging to write
+// tests for things like recovery from corruption.  Use this scoper to
+// ignore errors during the current test.  This applies globally (to
+// all connections).  The scoper can be nested, but is not thread-safe.
+//
+// Specific errors must be ignores, and all ignored errors must be

[erikwright (departed), 2013/06/11 18:54:19]

Grammar problems to the point that I don't know what this line means.

+// seen.
+//
+// TODO(shess): Wire things up so this can only be used from tests.
+// NOTE(shess): This does not comprehensively suppress errors at this
+// time.  If your test is handling database errors and you're hitting
+// a case not handled, contact me.
+// NOTE(shess): If you use this in production code, I will revert you.
+class SQL_EXPORT ScopedErrorIgnorer {

[erikwright (departed), 2013/06/11 18:54:19]

I'd have to scan sql/ to see what the local convention is, but I'm a big fan of
one class per file and would prefer to see this moved into
sql/scoped_error_ignorer.h, for example.

+ public:
+  ScopedErrorIgnorer();
+  ~ScopedErrorIgnorer();
+
+  // Add an error to ignore.  Extended error codes can be ignored
+  // specifically, or the base can be ignored as a group
+  // (SQLITE_IOERR_* versus SQLITE_IOERR).
+  void IgnoreError(int err);
+
+  // Allow containing test to check if the errors were encountered.
+  // Test is REQUIRED to call this before destruction.
+  // TODO(shess): How to handle ASSERT_X() cases which cause early
+  // return in tests?
+  bool CheckIgnoredErrors();
+
+  // Check if the error should be ignored.
+  static bool ShouldIgnoreError(int err);
+
+ private:
+  // Record whether CheckIgnoredErrors() has been called.
+  bool checked_;
+
+  // Errors to ignore.
+  std::set<int> ignore_errors_;
+
+  // Errors which have been ignored.
+  std::set<int> errors_ignored_;
+
+  ScopedErrorIgnorer* next_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedErrorIgnorer);
+};
+
 }  // namespace sql
 
 #endif  // SQL_CONNECTION_H_