Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1666363007: Cleanup includes of XLinkNames.h (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup includes of XLinkNames.h Remove includes which are not used, and use the imageSourceURL() method in one place to abstract away future uses of 'href'. BUG=584142 Committed: https://crrev.com/f7a45cc5e9fc48484d3b3205db8a7026b80e8caa Cr-Commit-Position: refs/heads/master@{#373866}

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
fs
4 years, 10 months ago (2016-02-05 17:41:49 UTC) #2
Stephen Chennney
LGTM I wish there was some way to indicate no-longer-needed includes when uploading changes, but ...
4 years, 10 months ago (2016-02-05 18:09:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666363007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666363007/1
4 years, 10 months ago (2016-02-05 18:54:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 19:09:00 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 19:10:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7a45cc5e9fc48484d3b3205db8a7026b80e8caa
Cr-Commit-Position: refs/heads/master@{#373866}

Powered by Google App Engine
This is Rietveld 408576698