content/renderer/media/audio_renderer_mixer_manager.h - Issue 1666363005: Switching audio clients to using RestartableAudioRendererSink interface as a sink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_renderer_mixer_manager.h

Issue 1666363005: Switching audio clients to using RestartableAudioRendererSink interface as a sink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: export fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_device_factory.cc ('K') | « content/renderer/media/audio_device_factory.cc ('k') | content/renderer/media/audio_renderer_mixer_manager.cc » ('j') | content/renderer/media/audio_renderer_mixer_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/audio_renderer_mixer_manager.h

diff --git a/content/renderer/media/audio_renderer_mixer_manager.h b/content/renderer/media/audio_renderer_mixer_manager.h

index fa8f96208577feecae438ab9525343cd04b17e9e..99fb595dbe52fab5a3249db8c7d610b662714171 100644

--- a/content/renderer/media/audio_renderer_mixer_manager.h

+++ b/content/renderer/media/audio_renderer_mixer_manager.h

@@ -127,6 +127,13 @@ class CONTENT_EXPORT AudioRendererMixerManager {

media::AudioRendererSink* sink_for_testing_;

+ // A helper to get output HW parameters in the absence of AudioOutputDevice.

DaleCurtis 2016/02/10 23:25:33 Methods always go above variables.

o1ka 2016/02/11 17:18:23 Done.

+ static media::AudioParameters GetOutputHWParams(

DaleCurtis 2016/02/10 23:25:33 Naming wise this should be something like GetHardw

o1ka 2016/02/11 17:18:23 Done.

+ int render_frame_id,

+ int session_id,

+ const std::string& device_id,

+ const url::Origin& security_origin);

DISALLOW_COPY_AND_ASSIGN(AudioRendererMixerManager);

};