Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: content/renderer/media/audio_renderer_mixer_manager.cc

Issue 1666363005: Switching audio clients to using RestartableAudioRendererSink interface as a sink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing RestartableAudioOutputDevice interface Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/audio_renderer_mixer_manager.h" 5 #include "content/renderer/media/audio_renderer_mixer_manager.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "content/renderer/media/audio_device_factory.h" 12 #include "content/renderer/media/audio_device_factory.h"
13
14 // Required for RestartableAudioOutputDeviceFactory::GetOutputHWConfig():
DaleCurtis 2016/02/08 19:10:25 We don't typically do comments like this in header
o1ka 2016/02/09 14:15:38 Done.
15 #include "content/renderer/media/restartable_audio_output_device_factory.h"
16
13 #include "media/audio/audio_output_device.h" 17 #include "media/audio/audio_output_device.h"
14 #include "media/base/audio_hardware_config.h" 18 #include "media/base/audio_hardware_config.h"
15 #include "media/base/audio_renderer_mixer.h" 19 #include "media/base/audio_renderer_mixer.h"
16 #include "media/base/audio_renderer_mixer_input.h" 20 #include "media/base/audio_renderer_mixer_input.h"
17 21
18 namespace content { 22 namespace content {
19 23
20 AudioRendererMixerManager::AudioRendererMixerManager() 24 AudioRendererMixerManager::AudioRendererMixerManager()
21 : sink_for_testing_(nullptr) {} 25 : sink_for_testing_(nullptr) {}
22 26
23 AudioRendererMixerManager::~AudioRendererMixerManager() { 27 AudioRendererMixerManager::~AudioRendererMixerManager() {
24 // References to AudioRendererMixers may be owned by garbage collected 28 // References to AudioRendererMixers may be owned by garbage collected
25 // objects. During process shutdown they may be leaked, so, transitively, 29 // objects. During process shutdown they may be leaked, so, transitively,
26 // |mixers_| may leak (i.e., may be non-empty at this time) as well. 30 // |mixers_| may leak (i.e., may be non-empty at this time) as well.
27 } 31 }
28 32
29 media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput( 33 media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput(
30 int source_render_frame_id, 34 int source_render_frame_id,
31 const std::string& device_id, 35 const std::string& device_id,
32 const url::Origin& security_origin) { 36 const url::Origin& security_origin) {
33 return new media::AudioRendererMixerInput( 37 return new media::AudioRendererMixerInput(
34 base::Bind(&AudioRendererMixerManager::GetMixer, base::Unretained(this), 38 base::Bind(&AudioRendererMixerManager::GetMixer, base::Unretained(this),
35 source_render_frame_id), 39 source_render_frame_id),
36 base::Bind(&AudioRendererMixerManager::RemoveMixer, 40 base::Bind(&AudioRendererMixerManager::RemoveMixer,
37 base::Unretained(this), source_render_frame_id), 41 base::Unretained(this), source_render_frame_id),
38 device_id, security_origin); 42 base::Bind(&RestartableAudioOutputDeviceFactory::GetOutputHWParams,
DaleCurtis 2016/02/08 19:10:25 This is great actually, I was just looking at doin
o1ka 2016/02/09 14:15:38 Great! Since we are moving towards output device s
43 source_render_frame_id, 0), // Session id is 0.
44 device_id,
45 security_origin);
39 } 46 }
40 47
41 void AudioRendererMixerManager::SetAudioRendererSinkForTesting( 48 void AudioRendererMixerManager::SetAudioRendererSinkForTesting(
42 media::AudioRendererSink* sink) { 49 media::AudioRendererSink* sink) {
43 sink_for_testing_ = sink; 50 sink_for_testing_ = sink;
44 } 51 }
45 52
46 media::AudioRendererMixer* AudioRendererMixerManager::GetMixer( 53 media::AudioRendererMixer* AudioRendererMixerManager::GetMixer(
47 int source_render_frame_id, 54 int source_render_frame_id,
48 const media::AudioParameters& params, 55 const media::AudioParameters& params,
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 int source_render_frame_id, 148 int source_render_frame_id,
142 const media::AudioParameters& params, 149 const media::AudioParameters& params,
143 const std::string& device_id, 150 const std::string& device_id,
144 const url::Origin& security_origin) 151 const url::Origin& security_origin)
145 : source_render_frame_id(source_render_frame_id), 152 : source_render_frame_id(source_render_frame_id),
146 params(params), 153 params(params),
147 device_id(device_id), 154 device_id(device_id),
148 security_origin(security_origin) {} 155 security_origin(security_origin) {}
149 156
150 } // namespace content 157 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698