Issue 16663009: Deprecate several unchecked accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16663009: Deprecate several unchecked accessors. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger

Modified:
7 years, 6 months ago

Reviewers:
Hannes Payer (out of office), payer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Deprecate several unchecked accessors. R=hpayer@google.com BUG=v8:1490 Committed: http://code.google.com/p/v8/source/detail?r=15123

Patch Set 2 : Deprecate even moar. #

Total comments: 2

Patch Set 3 : Addressed comments by Hannes Payer. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -103 lines)			Patch
M	src/mark-compact.cc	View	1 2	5 chunks	+12 lines, -19 lines	0 comments	Download
M	src/objects.h	View	1	7 chunks	+2 lines, -19 lines	0 comments	Download
M	src/objects-inl.h	View	1	7 chunks	+0 lines, -65 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

payer

LGTM! one nit https://codereview.chromium.org/16663009/diff/2001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/16663009/diff/2001/src/mark-compact.cc#newcode1505 src/mark-compact.cc:1505: code); that fits in one line

7 years, 6 months ago (2013-06-13 13:09:10 UTC) #2

Michael Starzinger

Addressed comments. Will land once tree is open again. https://codereview.chromium.org/16663009/diff/2001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/16663009/diff/2001/src/mark-compact.cc#newcode1505 src/mark-compact.cc:1505: ...

7 years, 6 months ago (2013-06-13 13:59:09 UTC) #3