Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: cc/raster/task_graph_work_queue.cc

Issue 1666283002: Reland - Refactor signaling in RWP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix refcounting issue. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/raster/task_graph_work_queue.cc
diff --git a/cc/raster/task_graph_work_queue.cc b/cc/raster/task_graph_work_queue.cc
index 29474023c6539a17ab44c9cc8b0b0d67645dd635..e929cc2dcd28fb0186c6ecc7f73ac690aee6f0d1 100644
--- a/cc/raster/task_graph_work_queue.cc
+++ b/cc/raster/task_graph_work_queue.cc
@@ -45,6 +45,18 @@ class CompareTaskNamespacePriority {
};
} // namespace
+TaskGraphWorkQueue::PrioritizedTask::PrioritizedTask(
+ Task* task,
+ TaskNamespace* task_namespace,
+ uint16_t category,
+ uint16_t priority)
+ : task(task),
+ task_namespace(task_namespace),
+ category(category),
+ priority(priority) {}
+
+TaskGraphWorkQueue::PrioritizedTask::~PrioritizedTask() {}
+
TaskGraphWorkQueue::TaskNamespace::TaskNamespace() {}
TaskGraphWorkQueue::TaskNamespace::~TaskNamespace() {}
@@ -97,9 +109,11 @@ void TaskGraphWorkQueue::ScheduleTasks(NamespaceToken token, TaskGraph* graph) {
continue;
// Skip if already running.
- if (std::find(task_namespace.running_tasks.begin(),
- task_namespace.running_tasks.end(),
- node.task) != task_namespace.running_tasks.end())
+ if (std::any_of(task_namespace.running_tasks.begin(),
+ task_namespace.running_tasks.end(),
+ [&node](const PrioritizedTask& task) {
+ return task.task == node.task;
+ }))
continue;
task_namespace.ready_to_run_tasks[node.category].push_back(PrioritizedTask(
@@ -127,9 +141,11 @@ void TaskGraphWorkQueue::ScheduleTasks(NamespaceToken token, TaskGraph* graph) {
continue;
// Skip if already running.
- if (std::find(task_namespace.running_tasks.begin(),
- task_namespace.running_tasks.end(),
- node.task) != task_namespace.running_tasks.end())
+ if (std::any_of(task_namespace.running_tasks.begin(),
+ task_namespace.running_tasks.end(),
+ [&node](const PrioritizedTask& task) {
+ return task.task == node.task;
+ }))
continue;
DCHECK(std::find(task_namespace.completed_tasks.begin(),
@@ -195,7 +211,7 @@ TaskGraphWorkQueue::PrioritizedTask TaskGraphWorkQueue::GetNextTaskToRun(
}
// Add task to |running_tasks|.
- task_namespace->running_tasks.push_back(task.task);
+ task_namespace->running_tasks.push_back(task);
return task;
}
@@ -205,8 +221,11 @@ void TaskGraphWorkQueue::CompleteTask(const PrioritizedTask& completed_task) {
scoped_refptr<Task> task(completed_task.task);
// Remove task from |running_tasks|.
- auto it = std::find(task_namespace->running_tasks.begin(),
- task_namespace->running_tasks.end(), task);
+ auto it = std::find_if(task_namespace->running_tasks.begin(),
+ task_namespace->running_tasks.end(),
+ [&completed_task](const PrioritizedTask& task) {
+ return task.task == completed_task.task;
+ });
DCHECK(it != task_namespace->running_tasks.end());
std::swap(*it, task_namespace->running_tasks.back());
task_namespace->running_tasks.pop_back();

Powered by Google App Engine
This is Rietveld 408576698