Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: Source/core/rendering/style/GridPosition.h

Issue 166623002: [CSS Grid Layout] Introduce an explicit type for resolved grid positions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix compilation issue Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/style/GridCoordinate.h ('k') | Source/core/rendering/style/GridResolvedPosition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/GridPosition.h
diff --git a/Source/core/rendering/style/GridPosition.h b/Source/core/rendering/style/GridPosition.h
index 778e453bc1524d704b6038d57126ff1ff41bdceb..bb404909546f68d114baf4c06bdc19c468e996c9 100644
--- a/Source/core/rendering/style/GridPosition.h
+++ b/Source/core/rendering/style/GridPosition.h
@@ -42,13 +42,6 @@ enum GridPositionType {
NamedGridAreaPosition // <ident>
};
-enum GridPositionSide {
- ColumnStartSide,
- ColumnEndSide,
- RowStartSide,
- RowEndSide
-};
-
class GridPosition {
public:
GridPosition()
@@ -57,20 +50,6 @@ public:
{
}
- static size_t adjustGridPositionForAfterEndSide(size_t resolvedPosition)
- {
- return resolvedPosition ? resolvedPosition - 1 : 0;
- }
-
- static size_t adjustGridPositionForSide(size_t resolvedPosition, GridPositionSide side)
- {
- // An item finishing on the N-th line belongs to the N-1-th cell.
- if (side == ColumnEndSide || side == RowEndSide)
- return adjustGridPositionForAfterEndSide(resolvedPosition);
-
- return resolvedPosition;
- }
-
bool isPositive() const { return integerPosition() > 0; }
GridPositionType type() const { return m_type; }
« no previous file with comments | « Source/core/rendering/style/GridCoordinate.h ('k') | Source/core/rendering/style/GridResolvedPosition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698