Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: Source/core/css/CSSGridTemplateAreasValue.cpp

Issue 166623002: [CSS Grid Layout] Introduce an explicit type for resolved grid positions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Applied review suggestions Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSGridTemplateAreasValue.cpp
diff --git a/Source/core/css/CSSGridTemplateAreasValue.cpp b/Source/core/css/CSSGridTemplateAreasValue.cpp
index d27c5b6955fd4ce4d20af5196973efe18059dc9d..a09cd5106793a06672be6df091966ba0d7c95d06 100644
--- a/Source/core/css/CSSGridTemplateAreasValue.cpp
+++ b/Source/core/css/CSSGridTemplateAreasValue.cpp
@@ -52,14 +52,14 @@ static String stringForPosition(const NamedGridAreaMap& gridAreaMap, size_t row,
NamedGridAreaMap::const_iterator end = gridAreaMap.end();
for (NamedGridAreaMap::const_iterator it = gridAreaMap.begin(); it != end; ++it) {
const GridCoordinate& coordinate = it->value;
- if (row >= coordinate.rows.initialPositionIndex && row <= coordinate.rows.finalPositionIndex)
+ if (row >= coordinate.rows.resolvedInitialPosition && row <= coordinate.rows.resolvedFinalPosition)
esprehn 2014/04/08 22:14:58 This compares the new type to a size_t?
candidates.append(it->key);
}
end = gridAreaMap.end();
for (NamedGridAreaMap::const_iterator it = gridAreaMap.begin(); it != end; ++it) {
const GridCoordinate& coordinate = it->value;
- if (column >= coordinate.columns.initialPositionIndex && column <= coordinate.columns.finalPositionIndex && candidates.contains(it->key))
+ if (column >= coordinate.columns.resolvedInitialPosition && column <= coordinate.columns.resolvedFinalPosition && candidates.contains(it->key))
return it->key;
}

Powered by Google App Engine
This is Rietveld 408576698