Source/core/rendering/RenderGrid.h - Issue 166623002: [CSS Grid Layout] Introduce an explicit type for resolved grid positions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.h

Issue 166623002: [CSS Grid Layout] Introduce an explicit type for resolved grid positions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | Source/core/rendering/style/GridResolvedPosition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderGrid.h

diff --git a/Source/core/rendering/RenderGrid.h b/Source/core/rendering/RenderGrid.h

index 7e7cf0acc57e585167dc96aad0914a5cb495eac8..73ec3dcc610070a9f7158df00c32d98bc02f01f7 100644

--- a/Source/core/rendering/RenderGrid.h

+++ b/Source/core/rendering/RenderGrid.h

@@ -124,12 +124,10 @@ private:

GridSpan resolveGridPositionsFromAutoPlacementPosition(const RenderBox*, GridTrackSizingDirection, size_t) const;

PassOwnPtr<GridSpan> resolveGridPositionsFromStyle(const RenderBox*, GridTrackSizingDirection) const;

- size_t resolveNamedGridLinePositionFromStyle(const GridPosition&, GridPositionSide) const;

- size_t resolveGridPositionFromStyle(const GridPosition&, GridPositionSide) const;

- PassOwnPtr<GridSpan> resolveGridPositionAgainstOppositePosition(size_t resolvedOppositePosition, const GridPosition&, GridPositionSide) const;

- PassOwnPtr<GridSpan> resolveNamedGridLinePositionAgainstOppositePosition(size_t resolvedOppositePosition, const GridPosition&, GridPositionSide) const;

- PassOwnPtr<GridSpan> resolveBeforeStartNamedGridLinePositionAgainstOppositePosition(size_t resolvedOppositePosition, const GridPosition&, const Vector<size_t>&) const;

- PassOwnPtr<GridSpan> resolveAfterEndNamedGridLinePositionAgainstOppositePosition(size_t resolvedOppositePosition, const GridPosition&, const Vector<size_t>&) const;

+ GridResolvedPosition resolveNamedGridLinePositionFromStyle(const GridPosition&, GridPositionSide) const;

+ GridResolvedPosition resolveGridPositionFromStyle(const GridPosition&, GridPositionSide) const;

+ PassOwnPtr<GridSpan> resolveGridPositionAgainstOppositePosition(const GridResolvedPosition& resolvedOppositePosition, const GridPosition&, GridPositionSide) const;

+ PassOwnPtr<GridSpan> resolveNamedGridLinePositionAgainstOppositePosition(const GridResolvedPosition& resolvedOppositePosition, const GridPosition&, GridPositionSide) const;

LayoutUnit gridAreaBreadthForChild(const RenderBox* child, GridTrackSizingDirection, const Vector<GridTrack>&) const;

« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | Source/core/rendering/style/GridResolvedPosition.h » ('J')