Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 1666073002: [turbofan] Remove the function reload hack for OSR. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Work-around safe point Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/code-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/arm64/macro-assembler-arm64.h" 8 #include "src/arm64/macro-assembler-arm64.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/compiler/code-generator-impl.h" 10 #include "src/compiler/code-generator-impl.h"
(...skipping 1430 matching lines...) Expand 10 before | Expand all | Expand 10 after
1441 if (info()->is_osr()) { 1441 if (info()->is_osr()) {
1442 // TurboFan OSR-compiled functions cannot be entered directly. 1442 // TurboFan OSR-compiled functions cannot be entered directly.
1443 __ Abort(kShouldNotDirectlyEnterOsrFunction); 1443 __ Abort(kShouldNotDirectlyEnterOsrFunction);
1444 1444
1445 // Unoptimized code jumps directly to this entrypoint while the unoptimized 1445 // Unoptimized code jumps directly to this entrypoint while the unoptimized
1446 // frame is still on the stack. Optimized code uses OSR values directly from 1446 // frame is still on the stack. Optimized code uses OSR values directly from
1447 // the unoptimized frame. Thus, all that needs to be done is to allocate the 1447 // the unoptimized frame. Thus, all that needs to be done is to allocate the
1448 // remaining stack slots. 1448 // remaining stack slots.
1449 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --"); 1449 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --");
1450 osr_pc_offset_ = __ pc_offset(); 1450 osr_pc_offset_ = __ pc_offset();
1451 // TODO(titzer): cannot address target function == local #-1
1452 __ ldr(x1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
1453 stack_shrink_slots -= OsrHelper(info()).UnoptimizedFrameSlots(); 1451 stack_shrink_slots -= OsrHelper(info()).UnoptimizedFrameSlots();
1454 } 1452 }
1455 1453
1456 // If frame()->needs_frame() is false, then 1454 // If frame()->needs_frame() is false, then
1457 // frame()->AlignSavedCalleeRegisterSlots() is guaranteed to return 0. 1455 // frame()->AlignSavedCalleeRegisterSlots() is guaranteed to return 0.
1458 if (csp.Is(masm()->StackPointer()) && frame()->needs_frame()) { 1456 if (csp.Is(masm()->StackPointer()) && frame()->needs_frame()) {
1459 // The system stack pointer requires 16-byte alignment at function call 1457 // The system stack pointer requires 16-byte alignment at function call
1460 // boundaries. 1458 // boundaries.
1461 1459
1462 stack_shrink_slots += frame()->AlignSavedCalleeRegisterSlots(); 1460 stack_shrink_slots += frame()->AlignSavedCalleeRegisterSlots();
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1713 padding_size -= kInstructionSize; 1711 padding_size -= kInstructionSize;
1714 } 1712 }
1715 } 1713 }
1716 } 1714 }
1717 1715
1718 #undef __ 1716 #undef __
1719 1717
1720 } // namespace compiler 1718 } // namespace compiler
1721 } // namespace internal 1719 } // namespace internal
1722 } // namespace v8 1720 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/code-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698