Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: src/compiler/arm/code-generator-arm.cc

Issue 1666073002: [turbofan] Remove the function reload hack for OSR. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Work-around safe point Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/arm/macro-assembler-arm.h" 7 #include "src/arm/macro-assembler-arm.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/compiler/code-generator-impl.h" 9 #include "src/compiler/code-generator-impl.h"
10 #include "src/compiler/gap-resolver.h" 10 #include "src/compiler/gap-resolver.h"
(...skipping 1120 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 if (info()->is_osr()) { 1131 if (info()->is_osr()) {
1132 // TurboFan OSR-compiled functions cannot be entered directly. 1132 // TurboFan OSR-compiled functions cannot be entered directly.
1133 __ Abort(kShouldNotDirectlyEnterOsrFunction); 1133 __ Abort(kShouldNotDirectlyEnterOsrFunction);
1134 1134
1135 // Unoptimized code jumps directly to this entrypoint while the unoptimized 1135 // Unoptimized code jumps directly to this entrypoint while the unoptimized
1136 // frame is still on the stack. Optimized code uses OSR values directly from 1136 // frame is still on the stack. Optimized code uses OSR values directly from
1137 // the unoptimized frame. Thus, all that needs to be done is to allocate the 1137 // the unoptimized frame. Thus, all that needs to be done is to allocate the
1138 // remaining stack slots. 1138 // remaining stack slots.
1139 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --"); 1139 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --");
1140 osr_pc_offset_ = __ pc_offset(); 1140 osr_pc_offset_ = __ pc_offset();
1141 // TODO(titzer): cannot address target function == local #-1
1142 __ ldr(r1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
1143 stack_shrink_slots -= OsrHelper(info()).UnoptimizedFrameSlots(); 1141 stack_shrink_slots -= OsrHelper(info()).UnoptimizedFrameSlots();
1144 } 1142 }
1145 1143
1146 const RegList saves_fp = descriptor->CalleeSavedFPRegisters(); 1144 const RegList saves_fp = descriptor->CalleeSavedFPRegisters();
1147 if (saves_fp != 0) { 1145 if (saves_fp != 0) {
1148 stack_shrink_slots += frame()->AlignSavedCalleeRegisterSlots(); 1146 stack_shrink_slots += frame()->AlignSavedCalleeRegisterSlots();
1149 } 1147 }
1150 if (stack_shrink_slots > 0) { 1148 if (stack_shrink_slots > 0) {
1151 __ sub(sp, sp, Operand(stack_shrink_slots * kPointerSize)); 1149 __ sub(sp, sp, Operand(stack_shrink_slots * kPointerSize));
1152 } 1150 }
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
1417 padding_size -= v8::internal::Assembler::kInstrSize; 1415 padding_size -= v8::internal::Assembler::kInstrSize;
1418 } 1416 }
1419 } 1417 }
1420 } 1418 }
1421 1419
1422 #undef __ 1420 #undef __
1423 1421
1424 } // namespace compiler 1422 } // namespace compiler
1425 } // namespace internal 1423 } // namespace internal
1426 } // namespace v8 1424 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698