Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1666063002: Fix ARM cross build: (Closed)

Created:
4 years, 10 months ago by Ivan Posva
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ARM cross build: - Don't try to pass '-mno-omit-leaf-frame-pointer' to the C++ compiler on any platform for now. BUG= Committed: https://github.com/dart-lang/sdk/commit/f28d46161b619e059130f8a5d1d124c31f488106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -34 lines) Patch
M tools/gyp/configurations_make.gypi View 8 chunks +109 lines, -28 lines 0 comments Download
M tools/gyp/configurations_xcode.gypi View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
TBR
4 years, 10 months ago (2016-02-04 05:37:07 UTC) #2
Ivan Posva
Committed patchset #1 (id:1) manually as f28d46161b619e059130f8a5d1d124c31f488106 (presubmit successful).
4 years, 10 months ago (2016-02-04 05:38:55 UTC) #4
Florian Schneider
4 years, 10 months ago (2016-02-05 17:08:11 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698