Chromium Code Reviews Chromium Code Reviews
Issue 1666003002:
bluetooth: Add Web Bluetooth blacklist checks to requestDevice. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-| Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html |
| diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..5055d066fc5a6ef4870f33210206c03653fb8984 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html |
| @@ -0,0 +1,43 @@ |
| +<!DOCTYPE html> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharness-helpers.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script src="resources/bluetooth-helpers.js"></script> |
| +<script> |
| +'use strict'; |
| + |
| +test(t => { assert_true(window.testRunner instanceof Object); t.done(); }, |
| + 'window.testRunner is required for the following tests.'); |
| + |
| +promise_test(() => { |
| + testRunner.setBluetoothMockDataSet('HeartRateAdapter'); |
| + return assert_promise_rejects_with_message( |
| + requestDeviceWithKeyDown( |
| + {filters: [{services: ['human_interface_device']}]}), |
| + new DOMException( |
| + 'requestDevice() called with a filter containing a blacklisted UUID.', |
| + 'SecurityError'), |
| + 'Requesting blacklisted service rejects.'); |
| +}, 'Reject with SecurityError if requesting a blacklisted service.'); |
| + |
| +promise_test(() => { |
| + testRunner.setBluetoothMockDataSet('HeartRateAndHIDAdapter'); |
| + return requestDeviceWithKeyDown( |
| + { |
| + filters: [{services: ['heart_rate']}], |
| + optionalServices: ['human_interface_device'] |
| + }) |
| + .then(device => device.gatt.connect()) |
| + .then(gattServer => { |
| + return assert_promise_rejects_with_message( |
| + gattServer.getPrimaryService('human_interface_device'), |
| + new DOMException( |
| + 'Origin is not allowed to access the service. Remember to add the ' + |
| + 'service to a filter or to optionalServices in requestDevice().', |
| + 'SecurityError'), |
| + 'Blacklisted service not accessible.'); |
| + }); |
| +}, 'Blacklisted UUID in optionalServices is removed and access not granted.'); |
| + |
| + |
|
ortuno
2016/02/12 16:41:47
Remove new lines.
scheib
2016/02/12 18:25:32
Done.
|
| +</script> |
