Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: sql/recovery_unittest.cc

Issue 1665913003: [sql] Use IGNORE conflict resolution in recovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zzsql_recover_autorecover_review
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sql/recovery.cc ('K') | « sql/recovery.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sql/recovery_unittest.cc
diff --git a/sql/recovery_unittest.cc b/sql/recovery_unittest.cc
index 4990e8388d9aee7be0d6d347197430c97557e0d9..e4fdb7b189ebe0bbc9fc5aa73ae20b1e79d1a478 100644
--- a/sql/recovery_unittest.cc
+++ b/sql/recovery_unittest.cc
@@ -371,9 +371,10 @@ TEST_F(SQLRecoveryTest, RecoverCorruptTable) {
EXPECT_EQ("10", ExecuteWithResults(&db(), kCountSql, "|", ","));
EXPECT_EQ("10", ExecuteWithResults(&db(), kDistinctSql, "|", ","));
- // The expected value was retained.
+ // Only one of the values is retained.
const char kSelectSql[] = "SELECT v FROM x WHERE id = 0";
- EXPECT_EQ("100", ExecuteWithResults(&db(), kSelectSql, "|", ","));
+ const std::string results = ExecuteWithResults(&db(), kSelectSql, "|", ",");
+ EXPECT_TRUE(results=="100" || results=="0") << "Actual results: " << results;
Scott Hess - ex-Googler 2016/02/03 22:37:20 REPLACE retained the last version encountered, IGN
}
TEST_F(SQLRecoveryTest, Meta) {
« sql/recovery.cc ('K') | « sql/recovery.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698