Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Side by Side Diff: src/compiler/pipeline.cc

Issue 1665853002: [Interpreter] Add explicit StackCheck bytecodes on function entry and back branches. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix unittests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | src/compiler/raw-machine-assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/pipeline.h" 5 #include "src/compiler/pipeline.h"
6 6
7 #include <fstream> // NOLINT(readability/streams) 7 #include <fstream> // NOLINT(readability/streams)
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/base/adapters.h" 10 #include "src/base/adapters.h"
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 struct GraphBuilderPhase { 508 struct GraphBuilderPhase {
509 static const char* phase_name() { return "graph builder"; } 509 static const char* phase_name() { return "graph builder"; }
510 510
511 void Run(PipelineData* data, Zone* temp_zone) { 511 void Run(PipelineData* data, Zone* temp_zone) {
512 bool stack_check = !data->info()->IsStub(); 512 bool stack_check = !data->info()->IsStub();
513 bool succeeded = false; 513 bool succeeded = false;
514 514
515 if (data->info()->shared_info()->HasBytecodeArray()) { 515 if (data->info()->shared_info()->HasBytecodeArray()) {
516 BytecodeGraphBuilder graph_builder(temp_zone, data->info(), 516 BytecodeGraphBuilder graph_builder(temp_zone, data->info(),
517 data->jsgraph()); 517 data->jsgraph());
518 succeeded = graph_builder.CreateGraph(stack_check); 518 succeeded = graph_builder.CreateGraph();
519 } else { 519 } else {
520 AstGraphBuilderWithPositions graph_builder( 520 AstGraphBuilderWithPositions graph_builder(
521 temp_zone, data->info(), data->jsgraph(), data->loop_assignment(), 521 temp_zone, data->info(), data->jsgraph(), data->loop_assignment(),
522 data->type_hint_analysis(), data->source_positions()); 522 data->type_hint_analysis(), data->source_positions());
523 succeeded = graph_builder.CreateGraph(stack_check); 523 succeeded = graph_builder.CreateGraph(stack_check);
524 } 524 }
525 525
526 if (!succeeded) { 526 if (!succeeded) {
527 data->set_compilation_failed(); 527 data->set_compilation_failed();
528 } 528 }
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
1486 tcf << AsC1VRegisterAllocationData("CodeGen", 1486 tcf << AsC1VRegisterAllocationData("CodeGen",
1487 data->register_allocation_data()); 1487 data->register_allocation_data());
1488 } 1488 }
1489 1489
1490 data->DeleteRegisterAllocationZone(); 1490 data->DeleteRegisterAllocationZone();
1491 } 1491 }
1492 1492
1493 } // namespace compiler 1493 } // namespace compiler
1494 } // namespace internal 1494 } // namespace internal
1495 } // namespace v8 1495 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | src/compiler/raw-machine-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698