Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/arm/builtins-arm.cc

Issue 1665853002: [Interpreter] Add explicit StackCheck bytecodes on function entry and back branches. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix unittests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 1024 matching lines...) Expand 10 before | Expand all | Expand 10 after
1035 __ b(&loop_header, ge); 1035 __ b(&loop_header, ge);
1036 } 1036 }
1037 1037
1038 // TODO(rmcilroy): List of things not currently dealt with here but done in 1038 // TODO(rmcilroy): List of things not currently dealt with here but done in
1039 // fullcodegen's prologue: 1039 // fullcodegen's prologue:
1040 // - Support profiler (specifically profiling_counter). 1040 // - Support profiler (specifically profiling_counter).
1041 // - Call ProfileEntryHookStub when isolate has a function_entry_hook. 1041 // - Call ProfileEntryHookStub when isolate has a function_entry_hook.
1042 // - Allow simulator stop operations if FLAG_stop_at is set. 1042 // - Allow simulator stop operations if FLAG_stop_at is set.
1043 // - Code aging of the BytecodeArray object. 1043 // - Code aging of the BytecodeArray object.
1044 1044
1045 // Perform stack guard check.
1046 {
1047 Label ok;
1048 __ LoadRoot(ip, Heap::kStackLimitRootIndex);
1049 __ cmp(sp, Operand(ip));
1050 __ b(hs, &ok);
1051 __ push(kInterpreterBytecodeArrayRegister);
1052 __ CallRuntime(Runtime::kStackGuard);
1053 __ pop(kInterpreterBytecodeArrayRegister);
1054 __ bind(&ok);
1055 }
1056
1057 // Load accumulator, register file, bytecode offset, dispatch table into 1045 // Load accumulator, register file, bytecode offset, dispatch table into
1058 // registers. 1046 // registers.
1059 __ LoadRoot(kInterpreterAccumulatorRegister, Heap::kUndefinedValueRootIndex); 1047 __ LoadRoot(kInterpreterAccumulatorRegister, Heap::kUndefinedValueRootIndex);
1060 __ add(kInterpreterRegisterFileRegister, fp, 1048 __ add(kInterpreterRegisterFileRegister, fp,
1061 Operand(InterpreterFrameConstants::kRegisterFilePointerFromFp)); 1049 Operand(InterpreterFrameConstants::kRegisterFilePointerFromFp));
1062 __ mov(kInterpreterBytecodeOffsetRegister, 1050 __ mov(kInterpreterBytecodeOffsetRegister,
1063 Operand(BytecodeArray::kHeaderSize - kHeapObjectTag)); 1051 Operand(BytecodeArray::kHeaderSize - kHeapObjectTag));
1064 __ LoadRoot(kInterpreterDispatchTableRegister, 1052 __ LoadRoot(kInterpreterDispatchTableRegister,
1065 Heap::kInterpreterTableRootIndex); 1053 Heap::kInterpreterTableRootIndex);
1066 __ add(kInterpreterDispatchTableRegister, kInterpreterDispatchTableRegister, 1054 __ add(kInterpreterDispatchTableRegister, kInterpreterDispatchTableRegister,
(...skipping 1633 matching lines...) Expand 10 before | Expand all | Expand 10 after
2700 } 2688 }
2701 } 2689 }
2702 2690
2703 2691
2704 #undef __ 2692 #undef __
2705 2693
2706 } // namespace internal 2694 } // namespace internal
2707 } // namespace v8 2695 } // namespace v8
2708 2696
2709 #endif // V8_TARGET_ARCH_ARM 2697 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698