Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1665843002:
Always build our own zlib. (Closed)
DescriptionAlways build our own zlib.
If we want to have an MSAN build, it'll help if we can build our own zlib
so that it's instrumented by MSAN.
Today we build our own zlib on Windows, but require the system to provide it
elsewhere. This just makes everyone build it (except Android framework of course).
This drops the SIMD files. They're only used to accelerate deflate
(compression), so they're not terribly interesting to us. Again, this only
really changes compression speed on Windows bots... pretty niche.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1665843002
Committed: https://skia.googlesource.com/skia/+/84b8d897c22144c52ee65fc29ca6580a5e2fcb73
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Always build our own zlib. If we want to have an MSAN build, it'll help if we can build our own zlib. Today we build our own zlib on Windows, but require the system to provide it elsewhere. This just makes everyone build it (except Android framework of course). This drops the SIMD files. They're only used to accelerate deflate (compression), so they're not terribly interesting to us. Again, this only really changes compression speed on Windows bots... pretty niche. BUG=skia: ========== to ========== Always build our own zlib. If we want to have an MSAN build, it'll help if we can build our own zlib. Today we build our own zlib on Windows, but require the system to provide it elsewhere. This just makes everyone build it (except Android framework of course). This drops the SIMD files. They're only used to accelerate deflate (compression), so they're not terribly interesting to us. Again, this only really changes compression speed on Windows bots... pretty niche. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665843002/1
Description was changed from ========== Always build our own zlib. If we want to have an MSAN build, it'll help if we can build our own zlib. Today we build our own zlib on Windows, but require the system to provide it elsewhere. This just makes everyone build it (except Android framework of course). This drops the SIMD files. They're only used to accelerate deflate (compression), so they're not terribly interesting to us. Again, this only really changes compression speed on Windows bots... pretty niche. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Always build our own zlib. If we want to have an MSAN build, it'll help if we can build our own zlib so that it's instrumented by MSAN. Today we build our own zlib on Windows, but require the system to provide it elsewhere. This just makes everyone build it (except Android framework of course). This drops the SIMD files. They're only used to accelerate deflate (compression), so they're not terribly interesting to us. Again, this only really changes compression speed on Windows bots... pretty niche. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
mtklein@chromium.org changed reviewers: + msarett@google.com
mtklein@google.com changed reviewers: + mtklein@google.com
This will have the nice side effect of breaking inflate() down into a few parts in our PNG decoding profiles: Running Time Self (ms) Symbol Name 46241.0ms 44.9% 46241.0 MOZ_Z_inflate_fast 18527.0ms 17.9% 18527.0 MOZ_Z_inflate 13503.0ms 13.1% 13503.0 MOZ_Z_adler32 12327.0ms 11.9% 12327.0 sk_paeth4_sse2(png_row_info_struct*, unsigned char*, unsigned char const*) 3410.0ms 3.3% 3410.0 MOZ_Z_crc32 3100.0ms 3.0% 3100.0 sk_avg4_sse2(png_row_info_struct*, unsigned char*, unsigned char const*)
lgtm Nice to get a little more info on the profile :). I'm reading that decompression is unaffected? Not that it matters a ton, given that Android has it's own zlib. And compression is mostly unaffected (except on Windows) because our other builders (that are responsible for their own zlibs) weren't using any SIMD?
On 2016/02/03 14:59:23, msarett wrote: > lgtm > > Nice to get a little more info on the profile :). > > I'm reading that decompression is unaffected? Not that it matters a ton, given > that Android has it's own zlib. > > And compression is mostly unaffected (except on Windows) because our other > builders (that are responsible for their own zlibs) weren't using any SIMD? Right all around.
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665843002/1
On 2016/02/03 14:54:55, mtklein wrote: > This will have the nice side effect of breaking inflate() down into a few parts > in our PNG decoding profiles: > > Running Time Self (ms) Symbol Name > 46241.0ms 44.9% 46241.0 MOZ_Z_inflate_fast > 18527.0ms 17.9% 18527.0 MOZ_Z_inflate > 13503.0ms 13.1% 13503.0 MOZ_Z_adler32 > 12327.0ms 11.9% 12327.0 sk_paeth4_sse2(png_row_info_struct*, unsigned char*, > unsigned char const*) > 3410.0ms 3.3% 3410.0 MOZ_Z_crc32 > 3100.0ms 3.0% 3100.0 sk_avg4_sse2(png_row_info_struct*, unsigned char*, > unsigned char const*) (Looking at this profile, you know what's coming next, right?)
Message was sent while issue was closed.
Description was changed from ========== Always build our own zlib. If we want to have an MSAN build, it'll help if we can build our own zlib so that it's instrumented by MSAN. Today we build our own zlib on Windows, but require the system to provide it elsewhere. This just makes everyone build it (except Android framework of course). This drops the SIMD files. They're only used to accelerate deflate (compression), so they're not terribly interesting to us. Again, this only really changes compression speed on Windows bots... pretty niche. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Always build our own zlib. If we want to have an MSAN build, it'll help if we can build our own zlib so that it's instrumented by MSAN. Today we build our own zlib on Windows, but require the system to provide it elsewhere. This just makes everyone build it (except Android framework of course). This drops the SIMD files. They're only used to accelerate deflate (compression), so they're not terribly interesting to us. Again, this only really changes compression speed on Windows bots... pretty niche. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/84b8d897c22144c52ee65fc29ca6580a5e2fcb73 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/84b8d897c22144c52ee65fc29ca6580a5e2fcb73
Message was sent while issue was closed.
On 2016/02/03 15:05:30, mtklein wrote: > On 2016/02/03 14:54:55, mtklein wrote: > > This will have the nice side effect of breaking inflate() down into a few > parts > > in our PNG decoding profiles: > > > > Running Time Self (ms) Symbol Name > > 46241.0ms 44.9% 46241.0 MOZ_Z_inflate_fast > > 18527.0ms 17.9% 18527.0 MOZ_Z_inflate > > 13503.0ms 13.1% 13503.0 MOZ_Z_adler32 > > 12327.0ms 11.9% 12327.0 sk_paeth4_sse2(png_row_info_struct*, unsigned > char*, > > unsigned char const*) > > 3410.0ms 3.3% 3410.0 MOZ_Z_crc32 > > 3100.0ms 3.0% 3100.0 sk_avg4_sse2(png_row_info_struct*, unsigned char*, > > unsigned char const*) > > (Looking at this profile, you know what's coming next, right?) Has to be SIMD for inflate :) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
