tests/XfermodeTest.cpp - Issue 166583002: Factory methods for heap-allocated SkPathEffect and SkXfermode objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/XfermodeTest.cpp

Issue 166583002: Factory methods for heap-allocated SkPathEffect and SkXfermode objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update experimental/PdfViewer Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/XfermodeTest.cpp

diff --git a/tests/XfermodeTest.cpp b/tests/XfermodeTest.cpp

index 7ac12fb089597671b4ec5c9547c6fa81ac48aa3e..4afa522de7af06aefc7b92f63e1a1e36aab57f6a 100644

--- a/tests/XfermodeTest.cpp

+++ b/tests/XfermodeTest.cpp

@@ -37,7 +37,7 @@ static void test_asMode(skiatest::Reporter* reporter) {

}

- SkXfermode* bogusXfer = new SkProcXfermode(bogusXfermodeProc);

+ SkXfermode* bogusXfer = SkProcXfermode::Create(bogusXfermodeProc);

SkXfermode::Mode reportedMode = ILLEGAL_MODE;

REPORTER_ASSERT(reporter, !bogusXfer->asMode(&reportedMode));

REPORTER_ASSERT(reporter, reportedMode == ILLEGAL_MODE);

« no previous file with comments | « tests/DrawPathTest.cpp ('k') | no next file » | no next file with comments »