src/utils/debugger/SkDebugCanvas.cpp - Issue 166583002: Factory methods for heap-allocated SkPathEffect and SkXfermode objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/debugger/SkDebugCanvas.cpp

Issue 166583002: Factory methods for heap-allocated SkPathEffect and SkXfermode objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update experimental/PdfViewer Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils/debugger/SkDebugCanvas.cpp

diff --git a/src/utils/debugger/SkDebugCanvas.cpp b/src/utils/debugger/SkDebugCanvas.cpp

index 32a65709546258c03ac6443a1923b9e1b661a441..07cb09f381252b96c7ad229af03ef52995df814c 100644

--- a/src/utils/debugger/SkDebugCanvas.cpp

+++ b/src/utils/debugger/SkDebugCanvas.cpp

@@ -118,7 +118,7 @@ static SkPMColor OverdrawXferModeProc(SkPMColor src, SkPMColor dst) {

class SkOverdrawFilter : public SkDrawFilter {

public:

SkOverdrawFilter() {

- fXferMode = new SkProcXfermode(OverdrawXferModeProc);

+ fXferMode = SkProcXfermode::Create(OverdrawXferModeProc);

}

virtual ~SkOverdrawFilter() {

« no previous file with comments | « src/effects/SkArithmeticMode.cpp ('k') | tests/DrawPathTest.cpp » ('j') | no next file with comments »