gm/dashcubics.cpp - Issue 166583002: Factory methods for heap-allocated SkPathEffect and SkXfermode objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/dashcubics.cpp

Issue 166583002: Factory methods for heap-allocated SkPathEffect and SkXfermode objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update experimental/PdfViewer Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/dashcubics.cpp

diff --git a/gm/dashcubics.cpp b/gm/dashcubics.cpp

index 5d874d4dc64482c06b5c6ca268958b32b7cabcb1..f99c0c34f4544975a0649a544a58adef7f1ea6c2 100644

--- a/gm/dashcubics.cpp

+++ b/gm/dashcubics.cpp

@@ -43,7 +43,7 @@ protected:

SkParsePath::FromSVGString(d, &path);

SkScalar intervals[] = { 5, 10 };

- SkPathEffect* pe = new SkDashPathEffect(intervals, 2, 0);

+ SkPathEffect* pe = SkDashPathEffect::Create(intervals, 2, 0);

SkPaint paint;

paint.setAntiAlias(true);

« no previous file with comments | « experimental/PdfViewer/SkPdfGraphicsState.cpp ('k') | gm/dashing.cpp » ('j') | no next file with comments »