Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: apps/benchmark/event.cc

Issue 1665823003: Only enable the Dart timeline for benchmarks (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/dart/embedder/dart_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/benchmark/event.cc
diff --git a/apps/benchmark/event.cc b/apps/benchmark/event.cc
index aa9ce706fa9e066e4ff7980657e764ed2d612efa..69f56d27f518394269a6330c2ec346828d0b021f 100644
--- a/apps/benchmark/event.cc
+++ b/apps/benchmark/event.cc
@@ -193,6 +193,7 @@ bool ParseEvents(base::ListValue* event_list, std::vector<Event>* result) {
base::DictionaryValue* event_dict;
if (!val->GetAsDictionary(&event_dict)) {
LOG(WARNING) << "Ignoring incorrect trace event (not a dictionary)";
+ LOG(WARNING) << *event_dict;
continue;
}
@@ -201,6 +202,7 @@ bool ParseEvents(base::ListValue* event_list, std::vector<Event>* result) {
std::string phase;
if (!event_dict->GetString("ph", &phase)) {
LOG(WARNING) << "Ignoring incorrect trace event (missing phase)";
+ LOG(WARNING) << *event_dict;
continue;
}
if (phase == "X") {
@@ -214,6 +216,7 @@ bool ParseEvents(base::ListValue* event_list, std::vector<Event>* result) {
if (!event_dict->GetString("name", &event.name)) {
LOG(ERROR) << "Incorrect trace event (no name)";
+ LOG(ERROR) << *event_dict;
return false;
}
@@ -224,6 +227,7 @@ bool ParseEvents(base::ListValue* event_list, std::vector<Event>* result) {
double timestamp;
if (!event_dict->GetDouble("ts", &timestamp)) {
LOG(WARNING) << "Ingoring incorrect trace event (no timestamp)";
+ LOG(WARNING) << *event_dict;
continue;
}
event.timestamp = base::TimeTicks::FromInternalValue(timestamp);
@@ -232,6 +236,7 @@ bool ParseEvents(base::ListValue* event_list, std::vector<Event>* result) {
double duration;
if (!event_dict->GetDouble("dur", &duration)) {
LOG(WARNING) << "Ignoring incorrect complete event (no duration)";
+ LOG(WARNING) << *event_dict;
continue;
}
« no previous file with comments | « no previous file | mojo/dart/embedder/dart_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698