Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issue 1665823003: Only enable the Dart timeline for benchmarks (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Only enable the Dart timeline for benchmarks - Print the event's map if we encounter an error in benchmark_app. - Add --dart-timeline flag to Dart content handler. - s/--complete-timeline/--dart-timeline. Sometimes we were generating a gigabyte of JSON text resulting in a timeout. This should fix that. R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d8a0f5964b1a7c522f14f2a3a1117d3ef47824bd

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -26 lines) Patch
M apps/benchmark/event.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M mojo/dart/embedder/dart_controller.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/dart/embedder/dart_controller.cc View 1 5 chunks +13 lines, -5 lines 0 comments Download
M mojo/dart/unittests/embedder_tester/dart_finalizer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/unittests/embedder_tester/dart_test.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/data/benchmarks View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/tools/data/rtt_benchmarks View 10 chunks +10 lines, -10 lines 0 comments Download
M services/dart/content_handler_main.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M services/dart/dart_tracing.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M services/tracing/tracing_app.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 10 months ago (2016-02-03 22:22:10 UTC) #3
zra
lgtm with suggestion to make flag names consistent. https://codereview.chromium.org/1665823003/diff/1/mojo/dart/embedder/dart_controller.h File mojo/dart/embedder/dart_controller.h (right): https://codereview.chromium.org/1665823003/diff/1/mojo/dart/embedder/dart_controller.h#newcode103 mojo/dart/embedder/dart_controller.h:103: bool ...
4 years, 10 months ago (2016-02-04 03:39:46 UTC) #4
Cutch
https://codereview.chromium.org/1665823003/diff/1/mojo/dart/embedder/dart_controller.h File mojo/dart/embedder/dart_controller.h (right): https://codereview.chromium.org/1665823003/diff/1/mojo/dart/embedder/dart_controller.h#newcode103 mojo/dart/embedder/dart_controller.h:103: bool enable_dart_timeline, On 2016/02/04 03:39:46, zra wrote: > dart_timeline_enabled, ...
4 years, 10 months ago (2016-02-04 22:13:23 UTC) #5
Cutch
4 years, 10 months ago (2016-02-04 22:13:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d8a0f5964b1a7c522f14f2a3a1117d3ef47824bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698