Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1665803002:
Do not upload to trusted partner's bucket if it is a dry run (Closed)
DescriptionDo not upload to trusted partner's bucket if it is a dry run
BUG=skia:3751
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1665803002
# Trybots do not exercise this code.
NOTRY=true
Committed: https://skia.googlesource.com/skia/+/37ed996f2d8960763578925a0a8210c59d59d8b0
Patch Set 1 : Initial upload #
Total comments: 4
Messages
Total messages: 13 (5 generated)
Description was changed from ========== Do not upload to trusted partner's bucket if it is a dry run BUG=skia:3751 ========== to ========== Do not upload to trusted partner's bucket if it is a dry run BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Do not upload to trusted partner's bucket if it is a dry run BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Do not upload to trusted partner's bucket if it is a dry run BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... # Trybots do not exercise this code. NOTRY=true ==========
rmistry@google.com changed reviewers: + borenet@google.com
https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py File tools/skp/recreate_skps.py (right): https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py#... tools/skp/recreate_skps.py:94: '<dry run>') Why not --upload_to_partner_bucket?
https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py File tools/skp/recreate_skps.py (right): https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py#... tools/skp/recreate_skps.py:94: '<dry run>') On 2016/02/03 13:06:34, borenet wrote: > Why not --upload_to_partner_bucket? I think it will be useful to have information whether this run is a dry run or not. The code here can then decide what it needs to do if it is a dry run. Maybe in the future it will upload dry runs to a different alternate_upload_dir to make obvious which dirs contain dry runs or not.
Code change LGTM, just want to understand the flow better. https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py File tools/skp/recreate_skps.py (right): https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py#... tools/skp/recreate_skps.py:94: '<dry run>') On 2016/02/03 13:09:28, rmistry wrote: > On 2016/02/03 13:06:34, borenet wrote: > > Why not --upload_to_partner_bucket? > > I think it will be useful to have information whether this run is a dry run or > not. The code here can then decide what it needs to do if it is a dry run. Maybe > in the future it will upload dry runs to a different alternate_upload_dir to > make obvious which dirs contain dry runs or not. Okay, I thought dry run meant that we didn't upload anything?
On 2016/02/03 13:12:02, borenet wrote: > Code change LGTM, just want to understand the flow better. > > https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py > File tools/skp/recreate_skps.py (right): > > https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py#... > tools/skp/recreate_skps.py:94: '<dry run>') > On 2016/02/03 13:09:28, rmistry wrote: > > On 2016/02/03 13:06:34, borenet wrote: > > > Why not --upload_to_partner_bucket? > > > > I think it will be useful to have information whether this run is a dry run or > > not. The code here can then decide what it needs to do if it is a dry run. > Maybe > > in the future it will upload dry runs to a different alternate_upload_dir to > > make obvious which dirs contain dry runs or not. > > Okay, I thought dry run meant that we didn't upload anything? It still uploads to GS when there is a dry run it just does not update the SKP_VERSION file. This was done so that there would be latest SKPs readily available if someone needs to download and test them.
https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py File tools/skp/recreate_skps.py (right): https://codereview.chromium.org/1665803002/diff/1/tools/skp/recreate_skps.py#... tools/skp/recreate_skps.py:94: '<dry run>') On 2016/02/03 13:12:02, borenet wrote: > On 2016/02/03 13:09:28, rmistry wrote: > > On 2016/02/03 13:06:34, borenet wrote: > > > Why not --upload_to_partner_bucket? > > > > I think it will be useful to have information whether this run is a dry run or > > not. The code here can then decide what it needs to do if it is a dry run. > Maybe > > in the future it will upload dry runs to a different alternate_upload_dir to > > make obvious which dirs contain dry runs or not. > > Okay, I thought dry run meant that we didn't upload anything? Ah, got it, thanks.
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665803002/1
Message was sent while issue was closed.
Description was changed from ========== Do not upload to trusted partner's bucket if it is a dry run BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... # Trybots do not exercise this code. NOTRY=true ========== to ========== Do not upload to trusted partner's bucket if it is a dry run BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... # Trybots do not exercise this code. NOTRY=true Committed: https://skia.googlesource.com/skia/+/37ed996f2d8960763578925a0a8210c59d59d8b0 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/37ed996f2d8960763578925a0a8210c59d59d8b0 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
